简柏林 / thingskit · Commits

Commit 5aac13b5277849e46b3c86efc4ec335b3df730b8

Authored by Andrew Shvayka
2 parents bb0533c5 3bcd596e

Merge branch 'develop/1.5' of github.com:thingsboard/thingsboard into develop/1.5

Inline Side-by-side
Showing 56 changed files with 849 additions and 224 deletions
... ... @@ -25,6 +25,7 @@ import com.typesafe.config.Config;
25 25 import com.typesafe.config.ConfigFactory;
26 26 import lombok.Getter;
27 27 import lombok.Setter;
  28 +import lombok.extern.slf4j.Slf4j;
28 29 import org.springframework.beans.factory.annotation.Autowired;
29 30 import org.springframework.beans.factory.annotation.Value;
30 31 import org.springframework.stereotype.Component;
... ... @@ -38,6 +39,7 @@ import org.thingsboard.server.common.data.id.EntityId;
38 39 import org.thingsboard.server.common.data.id.TenantId;
39 40 import org.thingsboard.server.common.data.plugin.ComponentLifecycleEvent;
40 41 import org.thingsboard.server.common.msg.TbMsg;
  42 +import org.thingsboard.server.common.msg.TbMsgDataType;
41 43 import org.thingsboard.server.common.msg.cluster.ServerAddress;
42 44 import org.thingsboard.server.common.transport.auth.DeviceAuthService;
43 45 import org.thingsboard.server.controller.plugin.PluginWebSocketMsgEndpoint;
... ... @@ -60,11 +62,13 @@ import org.thingsboard.server.service.cluster.routing.ClusterRoutingService;
60 62 import org.thingsboard.server.service.cluster.rpc.ClusterRpcService;
61 63 import org.thingsboard.server.service.component.ComponentDiscoveryService;
62 64
  65 +import java.io.IOException;
63 66 import java.io.PrintWriter;
64 67 import java.io.StringWriter;
65 68 import java.nio.charset.StandardCharsets;
66 69 import java.util.Optional;
67 70
  71 +@Slf4j
68 72 @Component
69 73 public class ActorSystemContext {
70 74 private static final String AKKA_CONF_FILE_NAME = "actor-system.conf";
... ... @@ -292,38 +296,49 @@ public class ActorSystemContext {
292 296 }
293 297
294 298 private void persistDebug(TenantId tenantId, EntityId entityId, String type, TbMsg tbMsg, Throwable error) {
295   - Event event = new Event();
296   - event.setTenantId(tenantId);
297   - event.setEntityId(entityId);
298   - event.setType(DataConstants.DEBUG);
299   -
300   - ObjectNode node = mapper.createObjectNode()
301   - .put("type", type)
302   - .put("server", getServerAddress())
303   - .put("entityId", tbMsg.getOriginator().getId().toString())
304   - .put("entityName", tbMsg.getOriginator().getEntityType().name())
305   - .put("msgId", tbMsg.getId().toString())
306   - .put("msgType", tbMsg.getType())
307   - .put("dataType", tbMsg.getDataType().name());
308   -
309   - ObjectNode mdNode = node.putObject("metadata");
310   - tbMsg.getMetaData().getData().forEach(mdNode::put);
  299 + try {
  300 + Event event = new Event();
  301 + event.setTenantId(tenantId);
  302 + event.setEntityId(entityId);
  303 + event.setType(DataConstants.DEBUG_RULE_NODE);
  304 +
  305 + String metadata = mapper.writeValueAsString(tbMsg.getMetaData().getData());
  306 +
  307 + ObjectNode node = mapper.createObjectNode()
  308 + .put("type", type)
  309 + .put("server", getServerAddress())
  310 + .put("entityId", tbMsg.getOriginator().getId().toString())
  311 + .put("entityName", tbMsg.getOriginator().getEntityType().name())
  312 + .put("msgId", tbMsg.getId().toString())
  313 + .put("msgType", tbMsg.getType())
  314 + .put("dataType", tbMsg.getDataType().name())
  315 + .put("data", convertToString(tbMsg.getDataType(), tbMsg.getData()))
  316 + .put("metadata", metadata);
  317 +
  318 + if (error != null) {
  319 + node = node.put("error", toString(error));
  320 + }
  321 +
  322 + event.setBody(node);
  323 + eventService.save(event);
  324 + } catch (IOException ex) {
  325 + log.warn("Failed to persist rule node debug message", ex);
  326 + }
  327 + }
311 328
312   - switch (tbMsg.getDataType()) {
  329 + private String convertToString(TbMsgDataType messageType, byte[] data) {
  330 + if (data == null) {
  331 + return null;
  332 + }
  333 + switch (messageType) {
  334 + case JSON:
  335 + case TEXT:
  336 + return new String(data, StandardCharsets.UTF_8);
313 337 case BINARY:
314   - node.put("data", Base64Utils.encodeUrlSafe(tbMsg.getData()));
315   - break;
  338 + return Base64Utils.encodeToString(data);
316 339 default:
317   - node.put("data", new String(tbMsg.getData(), StandardCharsets.UTF_8));
318   - break;
319   - }
320   -
321   - if (error != null) {
322   - node = node.put("error", toString(error));
  340 + throw new RuntimeException("Message type: " + messageType + " is not supported!");
323 341 }
324   -
325   - event.setBody(node);
326   - eventService.save(event);
327 342 }
328 343
329 344 public static Exception toException(Throwable error) {
... ...
... ... @@ -192,6 +192,8 @@ public class AnnotationComponentDiscoveryService implements ComponentDiscoverySe
192 192 NodeConfiguration config = configClazz.newInstance();
193 193 NodeConfiguration defaultConfiguration = config.defaultConfiguration();
194 194 nodeDefinition.setDefaultConfiguration(mapper.valueToTree(defaultConfiguration));
  195 + nodeDefinition.setUiResources(nodeAnnotation.uiResources());
  196 + nodeDefinition.setConfigDirective(nodeAnnotation.configDirective());
195 197 return nodeDefinition;
196 198 }
197 199
... ...
... ... @@ -51,6 +51,6 @@ public class AbstractRuleEngineControllerTest extends AbstractControllerTest {
51 51 TimePageLink pageLink = new TimePageLink(limit);
52 52 return doGetTypedWithTimePageLink("/api/events/{entityType}/{entityId}/{eventType}?tenantId={tenantId}&",
53 53 new TypeReference<TimePageData<Event>>() {
54   - }, pageLink, entityId.getEntityType(), entityId.getId(), DataConstants.DEBUG, tenantId.getId());
  54 + }, pageLink, entityId.getEntityType(), entityId.getId(), DataConstants.DEBUG_RULE_NODE, tenantId.getId());
55 55 }
56 56 }
... ...
... ... @@ -37,7 +37,7 @@ public class DataConstants {
37 37 public static final String ERROR = "ERROR";
38 38 public static final String LC_EVENT = "LC_EVENT";
39 39 public static final String STATS = "STATS";
40   - public static final String DEBUG = "DEBUG";
  40 + public static final String DEBUG_RULE_NODE = "DEBUG_RULE_NODE";
41 41
42 42 public static final String ONEWAY = "ONEWAY";
43 43 public static final String TWOWAY = "TWOWAY";
... ...
  1 +/**
  2 + * Copyright © 2016-2018 The Thingsboard Authors
  3 + *
  4 + * Licensed under the Apache License, Version 2.0 (the "License");
  5 + * you may not use this file except in compliance with the License.
  6 + * You may obtain a copy of the License at
  7 + *
  8 + * http://www.apache.org/licenses/LICENSE-2.0
  9 + *
  10 + * Unless required by applicable law or agreed to in writing, software
  11 + * distributed under the License is distributed on an "AS IS" BASIS,
  12 + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  13 + * See the License for the specific language governing permissions and
  14 + * limitations under the License.
  15 + */
  16 +package org.thingsboard.server.dao.exception;
  17 +
  18 +public class BufferLimitException extends RuntimeException {
  19 +
  20 + private static final long serialVersionUID = 4513762009041887588L;
  21 +
  22 + public BufferLimitException() {
  23 + super("Rate Limit Buffer is full");
  24 + }
  25 +}
... ...
... ... @@ -24,6 +24,7 @@ import com.google.common.util.concurrent.FutureCallback;
24 24 import com.google.common.util.concurrent.Futures;
25 25 import com.google.common.util.concurrent.ListenableFuture;
26 26 import com.google.common.util.concurrent.Uninterruptibles;
  27 +import org.thingsboard.server.dao.exception.BufferLimitException;
27 28 import org.thingsboard.server.dao.util.AsyncRateLimiter;
28 29
29 30 import javax.annotation.Nullable;
... ... @@ -35,9 +36,15 @@ public class RateLimitedResultSetFuture implements ResultSetFuture {
35 36 private final ListenableFuture<Void> rateLimitFuture;
36 37
37 38 public RateLimitedResultSetFuture(Session session, AsyncRateLimiter rateLimiter, Statement statement) {
38   - this.rateLimitFuture = rateLimiter.acquireAsync();
  39 + this.rateLimitFuture = Futures.withFallback(rateLimiter.acquireAsync(), t -> {
  40 + if (!(t instanceof BufferLimitException)) {
  41 + rateLimiter.release();
  42 + }
  43 + return Futures.immediateFailedFuture(t);
  44 + });
39 45 this.originalFuture = Futures.transform(rateLimitFuture,
40 46 (Function<Void, ResultSetFuture>) i -> executeAsyncWithRelease(rateLimiter, session, statement));
  47 +
41 48 }
42 49
43 50 @Override
... ... @@ -108,10 +115,7 @@ public class RateLimitedResultSetFuture implements ResultSetFuture {
108 115 try {
109 116 ResultSetFuture resultSetFuture = Uninterruptibles.getUninterruptibly(originalFuture);
110 117 resultSetFuture.addListener(listener, executor);
111   - } catch (CancellationException e) {
112   - cancel(false);
113   - return;
114   - } catch (ExecutionException e) {
  118 + } catch (CancellationException | ExecutionException e) {
115 119 Futures.immediateFailedFuture(e).addListener(listener, executor);
116 120 }
117 121 }, executor);
... ...
... ... @@ -23,6 +23,7 @@ import lombok.extern.slf4j.Slf4j;
23 23 import org.springframework.beans.factory.annotation.Value;
24 24 import org.springframework.scheduling.annotation.Scheduled;
25 25 import org.springframework.stereotype.Component;
  26 +import org.thingsboard.server.dao.exception.BufferLimitException;
26 27
27 28 import java.util.concurrent.*;
28 29 import java.util.concurrent.atomic.AtomicInteger;
... ... @@ -41,6 +42,9 @@ public class BufferedRateLimiter implements AsyncRateLimiter {
41 42
42 43 private final AtomicInteger maxQueueSize = new AtomicInteger();
43 44 private final AtomicInteger maxGrantedPermissions = new AtomicInteger();
  45 + private final AtomicInteger totalGranted = new AtomicInteger();
  46 + private final AtomicInteger totalReleased = new AtomicInteger();
  47 + private final AtomicInteger totalRequested = new AtomicInteger();
44 48
45 49 public BufferedRateLimiter(@Value("${cassandra.query.buffer_size}") int queueLimit,
46 50 @Value("${cassandra.query.concurrent_limit}") int permitsLimit,
... ... @@ -53,11 +57,13 @@ public class BufferedRateLimiter implements AsyncRateLimiter {
53 57
54 58 @Override
55 59 public ListenableFuture<Void> acquireAsync() {
  60 + totalRequested.incrementAndGet();
56 61 if (queue.isEmpty()) {
57 62 if (permits.incrementAndGet() <= permitsLimit) {
58 63 if (permits.get() > maxGrantedPermissions.get()) {
59 64 maxGrantedPermissions.set(permits.get());
60 65 }
  66 + totalGranted.incrementAndGet();
61 67 return Futures.immediateFuture(null);
62 68 }
63 69 permits.decrementAndGet();
... ... @@ -69,6 +75,7 @@ public class BufferedRateLimiter implements AsyncRateLimiter {
69 75 @Override
70 76 public void release() {
71 77 permits.decrementAndGet();
  78 + totalReleased.incrementAndGet();
72 79 reprocessQueue();
73 80 }
74 81
... ... @@ -80,6 +87,7 @@ public class BufferedRateLimiter implements AsyncRateLimiter {
80 87 }
81 88 LockedFuture lockedFuture = queue.poll();
82 89 if (lockedFuture != null) {
  90 + totalGranted.incrementAndGet();
83 91 lockedFuture.latch.countDown();
84 92 } else {
85 93 permits.decrementAndGet();
... ... @@ -112,17 +120,20 @@ public class BufferedRateLimiter implements AsyncRateLimiter {
112 120 LockedFuture lockedFuture = createLockedFuture();
113 121 if (!queue.offer(lockedFuture, 1, TimeUnit.SECONDS)) {
114 122 lockedFuture.cancelFuture();
115   - return Futures.immediateFailedFuture(new IllegalStateException("Rate Limit Buffer is full. Reject"));
  123 + return Futures.immediateFailedFuture(new BufferLimitException());
  124 + }
  125 + if(permits.get() < permitsLimit) {
  126 + reprocessQueue();
116 127 }
117 128 if(permits.get() < permitsLimit) {
118 129 reprocessQueue();
119 130 }
120 131 return lockedFuture.future;
121 132 } catch (InterruptedException e) {
122   - return Futures.immediateFailedFuture(new IllegalStateException("Rate Limit Task interrupted. Reject"));
  133 + return Futures.immediateFailedFuture(new BufferLimitException());
123 134 }
124 135 }
125   - return Futures.immediateFailedFuture(new IllegalStateException("Rate Limit Buffer is full. Reject"));
  136 + return Futures.immediateFailedFuture(new BufferLimitException());
126 137 }
127 138
128 139 @Scheduled(fixedDelayString = "${cassandra.query.rate_limit_print_interval_ms}")
... ... @@ -134,8 +145,11 @@ public class BufferedRateLimiter implements AsyncRateLimiter {
134 145 expiredCount++;
135 146 }
136 147 }
137   - log.info("Permits maxBuffer is [{}] max concurrent [{}] expired [{}] current granted [{}]", maxQueueSize.getAndSet(0),
138   - maxGrantedPermissions.getAndSet(0), expiredCount, permits.get());
  148 + log.info("Permits maxBuffer [{}] maxPermits [{}] expired [{}] currPermits [{}] currBuffer [{}] " +
  149 + "totalPermits [{}] totalRequests [{}] totalReleased [{}]",
  150 + maxQueueSize.getAndSet(0), maxGrantedPermissions.getAndSet(0), expiredCount,
  151 + permits.get(), queue.size(),
  152 + totalGranted.getAndSet(0), totalRequested.getAndSet(0), totalReleased.getAndSet(0));
139 153 }
140 154
141 155 private class LockedFuture {
... ...
... ... @@ -19,16 +19,17 @@ import com.datastax.driver.core.*;
19 19 import com.datastax.driver.core.exceptions.UnsupportedFeatureException;
20 20 import com.google.common.util.concurrent.Futures;
21 21 import com.google.common.util.concurrent.ListenableFuture;
  22 +import com.google.common.util.concurrent.MoreExecutors;
22 23 import org.junit.Test;
23 24 import org.junit.runner.RunWith;
24 25 import org.mockito.Mock;
25 26 import org.mockito.Mockito;
26 27 import org.mockito.runners.MockitoJUnitRunner;
27 28 import org.mockito.stubbing.Answer;
  29 +import org.thingsboard.server.dao.exception.BufferLimitException;
28 30 import org.thingsboard.server.dao.util.AsyncRateLimiter;
29 31
30   -import java.util.concurrent.ExecutionException;
31   -import java.util.concurrent.TimeoutException;
  32 +import java.util.concurrent.*;
32 33
33 34 import static org.junit.Assert.*;
34 35 import static org.mockito.Mockito.*;
... ... @@ -53,7 +54,7 @@ public class RateLimitedResultSetFutureTest {
53 54
54 55 @Test
55 56 public void doNotReleasePermissionIfRateLimitFutureFailed() throws InterruptedException {
56   - when(rateLimiter.acquireAsync()).thenReturn(Futures.immediateFailedFuture(new IllegalArgumentException()));
  57 + when(rateLimiter.acquireAsync()).thenReturn(Futures.immediateFailedFuture(new BufferLimitException()));
57 58 resultSetFuture = new RateLimitedResultSetFuture(session, rateLimiter, statement);
58 59 Thread.sleep(1000L);
59 60 verify(rateLimiter).acquireAsync();
... ... @@ -153,4 +154,29 @@ public class RateLimitedResultSetFutureTest {
153 154 verify(rateLimiter, times(1)).release();
154 155 }
155 156
  157 + @Test
  158 + public void expiredQueryReturnPermit() throws InterruptedException, ExecutionException {
  159 + CountDownLatch latch = new CountDownLatch(1);
  160 + ListenableFuture<Void> future = MoreExecutors.listeningDecorator(Executors.newFixedThreadPool(1)).submit(() -> {
  161 + latch.await();
  162 + return null;
  163 + });
  164 + when(rateLimiter.acquireAsync()).thenReturn(future);
  165 + resultSetFuture = new RateLimitedResultSetFuture(session, rateLimiter, statement);
  166 +
  167 + ListenableFuture<Row> transform = Futures.transform(resultSetFuture, ResultSet::one);
  168 +// TimeUnit.MILLISECONDS.sleep(200);
  169 + future.cancel(false);
  170 + latch.countDown();
  171 +
  172 + try {
  173 + transform.get();
  174 + fail();
  175 + } catch (Exception e) {
  176 + assertTrue(e instanceof ExecutionException);
  177 + }
  178 + verify(rateLimiter, times(1)).acquireAsync();
  179 + verify(rateLimiter, times(1)).release();
  180 + }
  181 +
156 182 }
\ No newline at end of file
... ...
... ... @@ -17,6 +17,7 @@ package org.thingsboard.server.dao.util;
17 17
18 18 import com.google.common.util.concurrent.*;
19 19 import org.junit.Test;
  20 +import org.thingsboard.server.dao.exception.BufferLimitException;
20 21
21 22 import javax.annotation.Nullable;
22 23 import java.util.concurrent.ExecutionException;
... ... @@ -61,8 +62,8 @@ public class BufferedRateLimiterTest {
61 62 } catch (Exception e) {
62 63 assertTrue(e instanceof ExecutionException);
63 64 Throwable actualCause = e.getCause();
64   - assertTrue(actualCause instanceof IllegalStateException);
65   - assertEquals("Rate Limit Buffer is full. Reject", actualCause.getMessage());
  65 + assertTrue(actualCause instanceof BufferLimitException);
  66 + assertEquals("Rate Limit Buffer is full", actualCause.getMessage());
66 67 }
67 68 }
68 69
... ...
... ... @@ -284,6 +284,7 @@
284 284 <exclude>src/sh/**</exclude>
285 285 <exclude>src/main/scripts/control/**</exclude>
286 286 <exclude>src/main/scripts/windows/**</exclude>
  287 + <exclude>src/main/resources/public/static/rulenode/**</exclude>
287 288 </excludes>
288 289 <mapping>
289 290 <proto>JAVADOC_STYLE</proto>
... ...
... ... @@ -29,5 +29,7 @@ public class NodeDefinition {
29 29 String[] relationTypes;
30 30 boolean customRelations;
31 31 JsonNode defaultConfiguration;
  32 + String[] uiResources;
  33 + String configDirective;
32 34
33 35 }
... ...
... ... @@ -45,6 +45,10 @@ public @interface RuleNode {
45 45
46 46 String[] relationTypes() default {"Success", "Failure"};
47 47
  48 + String[] uiResources() default {};
  49 +
  50 + String configDirective() default "";
  51 +
48 52 boolean customRelations() default false;
49 53
50 54 }
... ...
... ... @@ -35,7 +35,10 @@ import static org.thingsboard.rule.engine.DonAsynchron.withCallback;
35 35 nodeDetails = "Evaluate incoming Message with configured JS condition. " +
36 36 "If <b>True</b> - send Message via <b>True</b> chain, otherwise <b>False</b> chain is used." +
37 37 "Message payload can be accessed via <code>msg</code> property. For example <code>msg.temperature < 10;</code>" +
38   - "Message metadata can be accessed via <code>meta</code> property. For example <code>meta.customerName === 'John';</code>")
  38 + "Message metadata can be accessed via <code>metadata</code> property. For example <code>metadata.customerName === 'John';</code>",
  39 + uiResources = {"static/rulenode/rulenode-core-config.js"},
  40 + configDirective = "tbFilterNodeScriptConfig")
  41 +
39 42 public class TbJsFilterNode implements TbNode {
40 43
41 44 private TbJsFilterNodeConfiguration config;
... ... @@ -44,7 +47,7 @@ public class TbJsFilterNode implements TbNode {
44 47 @Override
45 48 public void init(TbNodeConfiguration configuration, TbNodeState state) throws TbNodeException {
46 49 this.config = TbNodeUtils.convert(configuration, TbJsFilterNodeConfiguration.class);
47   - this.jsEngine = new NashornJsEngine(config.getJsScript());
  50 + this.jsEngine = new NashornJsEngine(config.getJsScript(), "Filter");
48 51 }
49 52
50 53 @Override
... ...
... ... @@ -26,7 +26,7 @@ public class TbJsFilterNodeConfiguration implements NodeConfiguration {
26 26 @Override
27 27 public TbJsFilterNodeConfiguration defaultConfiguration() {
28 28 TbJsFilterNodeConfiguration configuration = new TbJsFilterNodeConfiguration();
29   - configuration.setJsScript("msg.passed < 15 && msg.name === 'Vit' && meta.temp == 10 && msg.bigObj.prop == 42;");
  29 + configuration.setJsScript("return msg.passed < 15 && msg.name === 'Vit' && metadata.temp == 10 && msg.bigObj.prop == 42;");
30 30 return configuration;
31 31 }
32 32 }
... ...
... ... @@ -36,7 +36,9 @@ import static org.thingsboard.rule.engine.DonAsynchron.withCallback;
36 36 nodeDetails = "Node executes configured JS script. Script should return array of next Chain names where Message should be routed. " +
37 37 "If Array is empty - message not routed to next Node. " +
38 38 "Message payload can be accessed via <code>msg</code> property. For example <code>msg.temperature < 10;</code> " +
39   - "Message metadata can be accessed via <code>meta</code> property. For example <code>meta.customerName === 'John';</code>")
  39 + "Message metadata can be accessed via <code>metadata</code> property. For example <code>metadata.customerName === 'John';</code>",
  40 + uiResources = {"static/rulenode/rulenode-core-config.js"},
  41 + configDirective = "tbFilterNodeSwitchConfig")
40 42 public class TbJsSwitchNode implements TbNode {
41 43
42 44 private TbJsSwitchNodeConfiguration config;
... ... @@ -45,22 +47,11 @@ public class TbJsSwitchNode implements TbNode {
45 47 @Override
46 48 public void init(TbNodeConfiguration configuration, TbNodeState state) throws TbNodeException {
47 49 this.config = TbNodeUtils.convert(configuration, TbJsSwitchNodeConfiguration.class);
48   - if (config.getAllowedRelations().size() < 1) {
49   - String message = "Switch node should have at least 1 relation";
50   - log.error(message);
51   - throw new IllegalStateException(message);
52   - }
53   - if (!config.isRouteToAllWithNoCheck()) {
54   - this.jsEngine = new NashornJsEngine(config.getJsScript());
55   - }
  50 + this.jsEngine = new NashornJsEngine(config.getJsScript(), "Switch");
56 51 }
57 52
58 53 @Override
59 54 public void onMsg(TbContext ctx, TbMsg msg) {
60   - if (config.isRouteToAllWithNoCheck()) {
61   - ctx.tellNext(msg, config.getAllowedRelations());
62   - return;
63   - }
64 55 ListeningExecutor jsExecutor = ctx.getJsExecutor();
65 56 withCallback(jsExecutor.executeAsync(() -> jsEngine.executeSwitch(toBindings(msg))),
66 57 result -> processSwitch(ctx, msg, result),
... ... @@ -68,15 +59,7 @@ public class TbJsSwitchNode implements TbNode {
68 59 }
69 60
70 61 private void processSwitch(TbContext ctx, TbMsg msg, Set<String> nextRelations) {
71   - if (validateRelations(nextRelations)) {
72   - ctx.tellNext(msg, nextRelations);
73   - } else {
74   - ctx.tellError(msg, new IllegalStateException("Unsupported relation for switch " + nextRelations));
75   - }
76   - }
77   -
78   - private boolean validateRelations(Set<String> nextRelations) {
79   - return config.getAllowedRelations().containsAll(nextRelations);
  62 + ctx.tellNext(msg, nextRelations);
80 63 }
81 64
82 65 private Bindings toBindings(TbMsg msg) {
... ...
... ... @@ -25,19 +25,15 @@ import java.util.Set;
25 25 public class TbJsSwitchNodeConfiguration implements NodeConfiguration {
26 26
27 27 private String jsScript;
28   - private Set<String> allowedRelations;
29   - private boolean routeToAllWithNoCheck;
30 28
31 29 @Override
32 30 public TbJsSwitchNodeConfiguration defaultConfiguration() {
33 31 TbJsSwitchNodeConfiguration configuration = new TbJsSwitchNodeConfiguration();
34   - configuration.setJsScript("function nextRelation(meta, msg) {\n" +
  32 + configuration.setJsScript("function nextRelation(metadata, msg) {\n" +
35 33 " return ['one','nine'];" +
36 34 "};\n" +
37 35 "\n" +
38   - "nextRelation(meta, msg);");
39   - configuration.setAllowedRelations(Sets.newHashSet("one", "two"));
40   - configuration.setRouteToAllWithNoCheck(false);
  36 + "return nextRelation(metadata, msg);");
41 37 return configuration;
42 38 }
43 39 }
... ...
... ... @@ -31,7 +31,9 @@ import org.thingsboard.server.common.msg.TbMsg;
31 31 configClazz = TbMsgTypeFilterNodeConfiguration.class,
32 32 nodeDescription = "Filter incoming messages by Message Type",
33 33 nodeDetails = "Evaluate incoming Message with configured JS condition. " +
34   - "If incoming MessageType is expected - send Message via <b>Success</b> chain, otherwise <b>Failure</b> chain is used.")
  34 + "If incoming MessageType is expected - send Message via <b>Success</b> chain, otherwise <b>Failure</b> chain is used.",
  35 + uiResources = {"static/rulenode/rulenode-core-config.js", "static/rulenode/rulenode-core-config.css"},
  36 + configDirective = "tbFilterNodeMessageTypeConfig")
35 37 public class TbMsgTypeFilterNode implements TbNode {
36 38
37 39 TbMsgTypeFilterNodeConfiguration config;
... ...
... ... @@ -33,7 +33,7 @@ public class TbMsgTypeFilterNodeConfiguration implements NodeConfiguration {
33 33 @Override
34 34 public TbMsgTypeFilterNodeConfiguration defaultConfiguration() {
35 35 TbMsgTypeFilterNodeConfiguration configuration = new TbMsgTypeFilterNodeConfiguration();
36   - configuration.setMessageTypes(Arrays.asList("GET_ATTRIBUTES","POST_ATTRIBUTES","POST_TELEMETRY","RPC_REQUEST"));
  36 + configuration.setMessageTypes(Arrays.asList("POST_ATTRIBUTES","POST_TELEMETRY","RPC_REQUEST"));
37 37 return configuration;
38 38 }
39 39 }
... ...
... ... @@ -34,14 +34,20 @@ import java.util.Set;
34 34 @Slf4j
35 35 public class NashornJsEngine {
36 36
37   - public static final String METADATA = "meta";
  37 + public static final String METADATA = "metadata";
38 38 public static final String DATA = "msg";
  39 +
  40 + private static final String JS_WRAPPER_PREFIX_TEMPLATE = "function %s(msg, metadata) { ";
  41 + private static final String JS_WRAPPER_SUFFIX_TEMPLATE = "}\n %s(msg, metadata);";
  42 +
39 43 private static NashornScriptEngineFactory factory = new NashornScriptEngineFactory();
40 44
41 45 private CompiledScript engine;
42 46
43   - public NashornJsEngine(String script) {
44   - engine = compileScript(script);
  47 + public NashornJsEngine(String script, String functionName) {
  48 + String jsWrapperPrefix = String.format(JS_WRAPPER_PREFIX_TEMPLATE, functionName);
  49 + String jsWrapperSuffix = String.format(JS_WRAPPER_SUFFIX_TEMPLATE, functionName);
  50 + engine = compileScript(jsWrapperPrefix + script + jsWrapperSuffix);
45 51 }
46 52
47 53 private static CompiledScript compileScript(String script) {
... ... @@ -58,15 +64,15 @@ public class NashornJsEngine {
58 64 public static Bindings bindMsg(TbMsg msg) {
59 65 try {
60 66 Bindings bindings = new SimpleBindings();
61   - bindings.put(METADATA, msg.getMetaData().getData());
62   -
63 67 if (ArrayUtils.isNotEmpty(msg.getData())) {
64 68 ObjectMapper mapper = new ObjectMapper();
65 69 JsonNode jsonNode = mapper.readTree(msg.getData());
66 70 Map map = mapper.treeToValue(jsonNode, Map.class);
67 71 bindings.put(DATA, map);
  72 + } else {
  73 + bindings.put(DATA, Collections.emptyMap());
68 74 }
69   -
  75 + bindings.put(METADATA, msg.getMetaData().getData());
70 76 return bindings;
71 77 } catch (Throwable th) {
72 78 throw new IllegalArgumentException("Cannot bind js args", th);
... ...
... ... @@ -42,7 +42,7 @@ import static org.thingsboard.server.common.data.DataConstants.*;
42 42 nodeDescription = "Add Message Originator Attributes or Latest Telemetry into Message Metadata",
43 43 nodeDetails = "If Attributes enrichment configured, <b>CLIENT/SHARED/SERVER</b> attributes are added into Message metadata " +
44 44 "with specific prefix: <i>cs/shared/ss</i>. To access those attributes in other nodes this template can be used " +
45   - "<code>meta.cs.temperature</code> or <code>meta.shared.limit</code> " +
  45 + "<code>metadata.cs.temperature</code> or <code>metadata.shared.limit</code> " +
46 46 "If Latest Telemetry enrichment configured, latest telemetry added into metadata without prefix.")
47 47 public class TbGetAttributesNode implements TbNode {
48 48
... ...
... ... @@ -30,7 +30,7 @@ import org.thingsboard.server.common.data.plugin.ComponentType;
30 30 nodeDescription = "Add Originators Customer Attributes or Latest Telemetry into Message Metadata",
31 31 nodeDetails = "If Attributes enrichment configured, server scope attributes are added into Message metadata. " +
32 32 "To access those attributes in other nodes this template can be used " +
33   - "<code>meta.temperature</code>. If Latest Telemetry enrichment configured, latest telemetry added into metadata")
  33 + "<code>metadata.temperature</code>. If Latest Telemetry enrichment configured, latest telemetry added into metadata")
34 34 public class TbGetCustomerAttributeNode extends TbEntityGetAttrNode<CustomerId> {
35 35
36 36 @Override
... ...
... ... @@ -32,7 +32,7 @@ import org.thingsboard.server.common.data.plugin.ComponentType;
32 32 "If multiple Related Entities are found, only first Entity is used for attributes enrichment, other entities are discarded. " +
33 33 "If Attributes enrichment configured, server scope attributes are added into Message metadata. " +
34 34 "To access those attributes in other nodes this template can be used " +
35   - "<code>meta.temperature</code>. If Latest Telemetry enrichment configured, latest telemetry added into metadata")
  35 + "<code>metadata.temperature</code>. If Latest Telemetry enrichment configured, latest telemetry added into metadata")
36 36 public class TbGetRelatedAttributeNode extends TbEntityGetAttrNode<EntityId> {
37 37
38 38 private TbGetRelatedAttrNodeConfiguration config;
... ...
... ... @@ -32,7 +32,7 @@ import org.thingsboard.server.common.data.plugin.ComponentType;
32 32 nodeDescription = "Add Originators Tenant Attributes or Latest Telemetry into Message Metadata",
33 33 nodeDetails = "If Attributes enrichment configured, server scope attributes are added into Message metadata. " +
34 34 "To access those attributes in other nodes this template can be used " +
35   - "<code>meta.temperature</code>. If Latest Telemetry enrichment configured, latest telemetry added into metadata")
  35 + "<code>metadata.temperature</code>. If Latest Telemetry enrichment configured, latest telemetry added into metadata")
36 36 public class TbGetTenantAttributeNode extends TbEntityGetAttrNode<TenantId> {
37 37
38 38 @Override
... ...
... ... @@ -30,7 +30,7 @@ import javax.script.Bindings;
30 30 configClazz = TbTransformMsgNodeConfiguration.class,
31 31 nodeDescription = "Change Message payload and Metadata using JavaScript",
32 32 nodeDetails = "JavaScript function recieve 2 input parameters that can be changed inside.<br/> " +
33   - "<code>meta</code> - is a Message metadata.<br/>" +
  33 + "<code>metadata</code> - is a Message metadata.<br/>" +
34 34 "<code>msg</code> - is a Message payload.<br/>Any properties can be changed/removed/added in those objects.")
35 35 public class TbTransformMsgNode extends TbAbstractTransformNode {
36 36
... ... @@ -40,7 +40,7 @@ public class TbTransformMsgNode extends TbAbstractTransformNode {
40 40 @Override
41 41 public void init(TbNodeConfiguration configuration, TbNodeState state) throws TbNodeException {
42 42 this.config = TbNodeUtils.convert(configuration, TbTransformMsgNodeConfiguration.class);
43   - this.jsEngine = new NashornJsEngine(config.getJsScript());
  43 + this.jsEngine = new NashornJsEngine(config.getJsScript(), "Transform");
44 44 setConfig(config);
45 45 }
46 46
... ...
... ... @@ -27,7 +27,7 @@ public class TbTransformMsgNodeConfiguration extends TbTransformNodeConfiguratio
27 27 public TbTransformMsgNodeConfiguration defaultConfiguration() {
28 28 TbTransformMsgNodeConfiguration configuration = new TbTransformMsgNodeConfiguration();
29 29 configuration.setStartNewChain(false);
30   - configuration.setJsScript("msg.passed = msg.passed * meta.temp; msg.bigObj.newProp = 'Ukraine' ");
  30 + configuration.setJsScript("return msg.passed = msg.passed * metadata.temp; msg.bigObj.newProp = 'Ukraine' ");
31 31 return configuration;
32 32 }
33 33 }
... ...
  1 +.tb-message-type-autocomplete .tb-not-found{display:block;line-height:1.5;height:48px}.tb-message-type-autocomplete .tb-not-found .tb-no-entries{line-height:48px}.tb-message-type-autocomplete li{height:auto!important;white-space:normal!important}
  2 +/*# sourceMappingURL=rulenode-core-config.css.map*/
\ No newline at end of file
... ...
  1 +!function(e){function t(s){if(a[s])return a[s].exports;var n=a[s]={exports:{},id:s,loaded:!1};return e[s].call(n.exports,n,n.exports,t),n.loaded=!0,n.exports}var a={};return t.m=e,t.c=a,t.p="/static/",t(0)}([function(e,t,a){e.exports=a(8)},function(e,t){},function(e,t){e.exports=' <section layout=column> <label translate class="tb-title no-padding" ng-class="{\'tb-required\': required}">tb.rulenode.message-types-filter</label> <md-chips id=message_type_chips ng-required=required readonly=readonly ng-model=messageTypes md-autocomplete-snap md-transform-chip=transformMessageTypeChip($chip) md-require-match=false> <md-autocomplete id=message_type md-no-cache=true md-selected-item=selectedMessageType md-search-text=messageTypeSearchText md-items="item in messageTypesSearch(messageTypeSearchText)" md-item-text=item.name md-min-length=0 placeholder="{{\'tb.rulenode.message-type\' | translate }}" md-menu-class=tb-message-type-autocomplete> <span md-highlight-text=messageTypeSearchText md-highlight-flags=^i>{{item}}</span> <md-not-found> <div class=tb-not-found> <div class=tb-no-entries ng-if="!messageTypeSearchText || !messageTypeSearchText.length"> <span translate>tb.rulenode.no-message-types-found</span> </div> <div ng-if="messageTypeSearchText && messageTypeSearchText.length"> <span translate translate-values=\'{ messageType: "{{messageTypeSearchText | truncate:true:6:&apos;...&apos;}}" }\'>tb.rulenode.no-message-type-matching</span> <span> <a translate ng-click="createMessageType($event, \'#message_type_chips\')">tb.rulenode.create-new-message-type</a> </span> </div> </div> </md-not-found> </md-autocomplete> <md-chip-template> <span>{{$chip.name}}</span> </md-chip-template> </md-chips> <div class=tb-error-messages ng-messages=ngModelCtrl.$error role=alert> <div translate ng-message=messageTypes class=tb-error-message>tb.rulenode.message-types-required</div> </div> </section>'},function(e,t){e.exports=" <section layout=column> <label translate class=\"tb-title no-padding\">tb.rulenode.filter</label> <tb-js-func ng-model=configuration.jsScript function-name=Filter function-args=\"{{ ['msg', 'metadata'] }}\" no-validate=true> </tb-js-func> </section> "},function(e,t){e.exports=" <section layout=column> <label translate class=\"tb-title no-padding\">tb.rulenode.switch</label> <tb-js-func ng-model=configuration.jsScript function-name=Switch function-args=\"{{ ['msg', 'metadata'] }}\" no-validate=true> </tb-js-func> </section> "},function(e,t,a){"use strict";function s(e){return e&&e.__esModule?e:{default:e}}function n(e,t,a){var s=function(s,n,r,l){function u(){if(l.$viewValue){for(var e=[],t=0;t<s.messageTypes.length;t++)e.push(s.messageTypes[t].value);l.$viewValue.messageTypes=e,o()}}function o(){if(s.required){var e=!(!l.$viewValue.messageTypes||!l.$viewValue.messageTypes.length);l.$setValidity("messageTypes",e)}else l.$setValidity("messageTypes",!0)}var c=i.default;n.html(c),s.selectedMessageType=null,s.messageTypeSearchText=null,s.ngModelCtrl=l;var d=[];for(var p in a.messageType){var m={name:a.messageType[p].name,value:a.messageType[p].value};d.push(m)}s.transformMessageTypeChip=function(e){var a,s=t("filter")(d,{name:e},!0);return a=s&&s.length?angular.copy(s[0]):{name:e,value:e}},s.messageTypesSearch=function(e){var a=e?t("filter")(d,{name:e}):d;return a.map(function(e){return e.name})},s.createMessageType=function(e,t){var a=angular.element(t,n)[0].firstElementChild,s=angular.element(a),r=s.scope().$mdChipsCtrl.getChipBuffer();e.preventDefault(),e.stopPropagation(),s.scope().$mdChipsCtrl.appendChip(r.trim()),s.scope().$mdChipsCtrl.resetChipBuffer()},l.$render=function(){var e=l.$viewValue,t=[];if(e&&e.messageTypes)for(var n=0;n<e.messageTypes.length;n++){var r=e.messageTypes[n];a.messageType[r]?t.push(angular.copy(a.messageType[r])):t.push({name:r,value:r})}s.messageTypes=t,s.$watch("messageTypes",function(e,t){angular.equals(e,t)||u()},!0)},e(n.contents())(s)};return{restrict:"E",require:"^ngModel",scope:{required:"=ngRequired",readonly:"=ngReadonly"},link:s}}n.$inject=["$compile","$filter","ruleNodeTypes"],Object.defineProperty(t,"__esModule",{value:!0}),t.default=n,a(1);var r=a(2),i=s(r)},function(e,t,a){"use strict";function s(e){return e&&e.__esModule?e:{default:e}}function n(e){var t=function(t,a,s,n){var r=i.default;a.html(r),t.$watch("configuration",function(e,a){angular.equals(e,a)||n.$setViewValue(t.configuration)}),n.$render=function(){t.configuration=n.$viewValue},e(a.contents())(t)};return{restrict:"E",require:"^ngModel",scope:{},link:t}}n.$inject=["$compile"],Object.defineProperty(t,"__esModule",{value:!0}),t.default=n;var r=a(3),i=s(r)},function(e,t,a){"use strict";function s(e){return e&&e.__esModule?e:{default:e}}function n(e){var t=function(t,a,s,n){var r=i.default;a.html(r),t.$watch("configuration",function(e,a){angular.equals(e,a)||n.$setViewValue(t.configuration)}),n.$render=function(){t.configuration=n.$viewValue},e(a.contents())(t)};return{restrict:"E",require:"^ngModel",scope:{},link:t}}n.$inject=["$compile"],Object.defineProperty(t,"__esModule",{value:!0}),t.default=n;var r=a(4),i=s(r)},function(e,t,a){"use strict";function s(e){return e&&e.__esModule?e:{default:e}}Object.defineProperty(t,"__esModule",{value:!0});var n=a(11),r=s(n),i=a(6),l=s(i),u=a(5),o=s(u),c=a(7),d=s(c),p=a(10),m=s(p);t.default=angular.module("thingsboard.ruleChain.config",[r.default]).directive("tbFilterNodeScriptConfig",l.default).directive("tbFilterNodeMessageTypeConfig",o.default).directive("tbFilterNodeSwitchConfig",d.default).config(m.default).name},function(e,t){"use strict";function a(e){var t={tb:{rulenode:{filter:"Filter",switch:"Switch","message-type":"Message type","message-types-filter":"Message types filter","no-message-types-found":"No message types found","no-message-type-matching":"'{{messageType}}' not found.","create-new-message-type":"Create a new one!","message-types-required":"Message types are required."}}};angular.merge(e.en_US,t)}Object.defineProperty(t,"__esModule",{value:!0}),t.default=a},function(e,t,a){"use strict";function s(e){return e&&e.__esModule?e:{default:e}}function n(e,t){(0,i.default)(t);for(var a in t){var s=t[a];e.translations(a,s)}}n.$inject=["$translateProvider","locales"],Object.defineProperty(t,"__esModule",{value:!0}),t.default=n;var r=a(9),i=s(r)},function(e,t){"use strict";Object.defineProperty(t,"__esModule",{value:!0}),t.default=angular.module("thingsboard.ruleChain.config.types",[]).constant("ruleNodeTypes",{messageType:{POST_ATTRIBUTES:{name:"Post attributes",value:"POST_ATTRIBUTES"},POST_TELEMETRY:{name:"Post telemetry",value:"POST_TELEMETRY"},RPC_REQUEST:{name:"RPC Request",value:"RPC_REQUEST"}}}).name}]);
  2 +//# sourceMappingURL=rulenode-core-config.js.map
\ No newline at end of file
... ...
... ... @@ -51,7 +51,7 @@ public class TbJsFilterNodeTest {
51 51
52 52 @Test
53 53 public void falseEvaluationDoNotSendMsg() throws TbNodeException {
54   - initWithScript("10 > 15;");
  54 + initWithScript("return 10 > 15;");
55 55 TbMsg msg = new TbMsg(UUIDs.timeBased(), "USER", null, new TbMsgMetaData(), "{}".getBytes());
56 56
57 57 mockJsExecutor();
... ... @@ -64,7 +64,7 @@ public class TbJsFilterNodeTest {
64 64
65 65 @Test
66 66 public void notValidMsgDataThrowsException() throws TbNodeException {
67   - initWithScript("10 > 15;");
  67 + initWithScript("return 10 > 15;");
68 68 TbMsg msg = new TbMsg(UUIDs.timeBased(), "USER", null, new TbMsgMetaData(), new byte[4]);
69 69
70 70 when(ctx.getJsExecutor()).thenReturn(executor);
... ... @@ -77,7 +77,7 @@ public class TbJsFilterNodeTest {
77 77
78 78 @Test
79 79 public void exceptionInJsThrowsException() throws TbNodeException {
80   - initWithScript("meta.temp.curr < 15;");
  80 + initWithScript("return metadata.temp.curr < 15;");
81 81 TbMsgMetaData metaData = new TbMsgMetaData();
82 82 TbMsg msg = new TbMsg(UUIDs.timeBased(), "USER", null, metaData, "{}".getBytes());
83 83 mockJsExecutor();
... ... @@ -89,12 +89,12 @@ public class TbJsFilterNodeTest {
89 89
90 90 @Test(expected = IllegalArgumentException.class)
91 91 public void notValidScriptThrowsException() throws TbNodeException {
92   - initWithScript("10 > 15 asdq out");
  92 + initWithScript("return 10 > 15 asdq out");
93 93 }
94 94
95 95 @Test
96 96 public void metadataConditionCanBeFalse() throws TbNodeException {
97   - initWithScript("meta.humidity < 15;");
  97 + initWithScript("return metadata.humidity < 15;");
98 98 TbMsgMetaData metaData = new TbMsgMetaData();
99 99 metaData.putValue("temp", "10");
100 100 metaData.putValue("humidity", "99");
... ... @@ -109,7 +109,7 @@ public class TbJsFilterNodeTest {
109 109
110 110 @Test
111 111 public void metadataConditionCanBeTrue() throws TbNodeException {
112   - initWithScript("meta.temp < 15;");
  112 + initWithScript("return metadata.temp < 15;");
113 113 TbMsgMetaData metaData = new TbMsgMetaData();
114 114 metaData.putValue("temp", "10");
115 115 metaData.putValue("humidity", "99");
... ... @@ -123,7 +123,7 @@ public class TbJsFilterNodeTest {
123 123
124 124 @Test
125 125 public void msgJsonParsedAndBinded() throws TbNodeException {
126   - initWithScript("msg.passed < 15 && msg.name === 'Vit' && meta.temp == 10 && msg.bigObj.prop == 42;");
  126 + initWithScript("return msg.passed < 15 && msg.name === 'Vit' && metadata.temp == 10 && msg.bigObj.prop == 42;");
127 127 TbMsgMetaData metaData = new TbMsgMetaData();
128 128 metaData.putValue("temp", "10");
129 129 metaData.putValue("humidity", "99");
... ...
... ... @@ -53,27 +53,16 @@ public class TbJsSwitchNodeTest {
53 53 private ListeningExecutor executor;
54 54
55 55 @Test
56   - public void routeToAllDoNotEvaluatesJs() throws TbNodeException {
57   - HashSet<String> relations = Sets.newHashSet("one", "two");
58   - initWithScript("test qwerty", relations, true);
59   - TbMsg msg = new TbMsg(UUIDs.timeBased(), "USER", null, new TbMsgMetaData(), "{}".getBytes());
60   -
61   - node.onMsg(ctx, msg);
62   - verify(ctx).tellNext(msg, relations);
63   - verifyNoMoreInteractions(ctx, executor);
64   - }
65   -
66   - @Test
67 56 public void multipleRoutesAreAllowed() throws TbNodeException {
68   - String jsCode = "function nextRelation(meta, msg) {\n" +
69   - " if(msg.passed == 5 && meta.temp == 10)\n" +
  57 + String jsCode = "function nextRelation(metadata, msg) {\n" +
  58 + " if(msg.passed == 5 && metadata.temp == 10)\n" +
70 59 " return ['three', 'one']\n" +
71 60 " else\n" +
72 61 " return 'two';\n" +
73 62 "};\n" +
74 63 "\n" +
75   - "nextRelation(meta, msg);";
76   - initWithScript(jsCode, Sets.newHashSet("one", "two", "three"), false);
  64 + "return nextRelation(metadata, msg);";
  65 + initWithScript(jsCode);
77 66 TbMsgMetaData metaData = new TbMsgMetaData();
78 67 metaData.putValue("temp", "10");
79 68 metaData.putValue("humidity", "99");
... ... @@ -89,15 +78,15 @@ public class TbJsSwitchNodeTest {
89 78
90 79 @Test
91 80 public void allowedRelationPassed() throws TbNodeException {
92   - String jsCode = "function nextRelation(meta, msg) {\n" +
93   - " if(msg.passed == 5 && meta.temp == 10)\n" +
  81 + String jsCode = "function nextRelation(metadata, msg) {\n" +
  82 + " if(msg.passed == 5 && metadata.temp == 10)\n" +
94 83 " return 'one'\n" +
95 84 " else\n" +
96 85 " return 'two';\n" +
97 86 "};\n" +
98 87 "\n" +
99   - "nextRelation(meta, msg);";
100   - initWithScript(jsCode, Sets.newHashSet("one", "two"), false);
  88 + "return nextRelation(metadata, msg);";
  89 + initWithScript(jsCode);
101 90 TbMsgMetaData metaData = new TbMsgMetaData();
102 91 metaData.putValue("temp", "10");
103 92 metaData.putValue("humidity", "99");
... ... @@ -111,32 +100,9 @@ public class TbJsSwitchNodeTest {
111 100 verify(ctx).tellNext(msg, Sets.newHashSet("one"));
112 101 }
113 102
114   - @Test
115   - public void unknownRelationThrowsException() throws TbNodeException {
116   - String jsCode = "function nextRelation(meta, msg) {\n" +
117   - " return ['one','nine'];" +
118   - "};\n" +
119   - "\n" +
120   - "nextRelation(meta, msg);";
121   - initWithScript(jsCode, Sets.newHashSet("one", "two"), false);
122   - TbMsgMetaData metaData = new TbMsgMetaData();
123   - metaData.putValue("temp", "10");
124   - metaData.putValue("humidity", "99");
125   - String rawJson = "{\"name\": \"Vit\", \"passed\": 5}";
126   -
127   - TbMsg msg = new TbMsg(UUIDs.timeBased(), "USER", null, metaData, rawJson.getBytes());
128   - mockJsExecutor();
129   -
130   - node.onMsg(ctx, msg);
131   - verify(ctx).getJsExecutor();
132   - verifyError(msg, "Unsupported relation for switch [nine, one]", IllegalStateException.class);
133   - }
134   -
135   - private void initWithScript(String script, Set<String> relations, boolean routeToAll) throws TbNodeException {
  103 + private void initWithScript(String script) throws TbNodeException {
136 104 TbJsSwitchNodeConfiguration config = new TbJsSwitchNodeConfiguration();
137 105 config.setJsScript(script);
138   - config.setAllowedRelations(relations);
139   - config.setRouteToAllWithNoCheck(routeToAll);
140 106 ObjectMapper mapper = new ObjectMapper();
141 107 TbNodeConfiguration nodeConfiguration = new TbNodeConfiguration(mapper.valueToTree(config));
142 108
... ...
... ... @@ -51,7 +51,7 @@ public class TbTransformMsgNodeTest {
51 51
52 52 @Test
53 53 public void metadataCanBeUpdated() throws TbNodeException {
54   - initWithScript("meta.temp = meta.temp * 10;");
  54 + initWithScript("return metadata.temp = metadata.temp * 10;");
55 55 TbMsgMetaData metaData = new TbMsgMetaData();
56 56 metaData.putValue("temp", "7");
57 57 metaData.putValue("humidity", "99");
... ... @@ -70,7 +70,7 @@ public class TbTransformMsgNodeTest {
70 70
71 71 @Test
72 72 public void metadataCanBeAdded() throws TbNodeException {
73   - initWithScript("meta.newAttr = meta.humidity - msg.passed;");
  73 + initWithScript("return metadata.newAttr = metadata.humidity - msg.passed;");
74 74 TbMsgMetaData metaData = new TbMsgMetaData();
75 75 metaData.putValue("temp", "7");
76 76 metaData.putValue("humidity", "99");
... ... @@ -89,7 +89,7 @@ public class TbTransformMsgNodeTest {
89 89
90 90 @Test
91 91 public void payloadCanBeUpdated() throws TbNodeException {
92   - initWithScript("msg.passed = msg.passed * meta.temp; msg.bigObj.newProp = 'Ukraine' ");
  92 + initWithScript("return msg.passed = msg.passed * metadata.temp; msg.bigObj.newProp = 'Ukraine' ");
93 93 TbMsgMetaData metaData = new TbMsgMetaData();
94 94 metaData.putValue("temp", "7");
95 95 metaData.putValue("humidity", "99");
... ...
... ... @@ -15,7 +15,7 @@
15 15 },
16 16 "dependencies": {
17 17 "@flowjs/ng-flow": "^2.7.1",
18   - "ace-builds": "^1.2.5",
  18 + "ace-builds": "1.3.1",
19 19 "angular": "1.5.8",
20 20 "angular-animate": "1.5.8",
21 21 "angular-aria": "1.5.8",
... ...
... ... @@ -30,6 +30,9 @@ const httpProxy = require('http-proxy');
30 30 const forwardHost = 'localhost';
31 31 const forwardPort = 8080;
32 32
  33 +const ruleNodeUiforwardHost = 'localhost';
  34 +const ruleNodeUiforwardPort = 8080;
  35 +
33 36 const app = express();
34 37 const server = http.createServer(app);
35 38
... ... @@ -52,17 +55,34 @@ const apiProxy = httpProxy.createProxyServer({
52 55 }
53 56 });
54 57
  58 +const ruleNodeUiApiProxy = httpProxy.createProxyServer({
  59 + target: {
  60 + host: ruleNodeUiforwardHost,
  61 + port: ruleNodeUiforwardPort
  62 + }
  63 +});
  64 +
55 65 apiProxy.on('error', function (err, req, res) {
56 66 console.warn('API proxy error: ' + err);
57 67 res.end('Error.');
58 68 });
59 69
  70 +ruleNodeUiApiProxy.on('error', function (err, req, res) {
  71 + console.warn('RuleNode UI API proxy error: ' + err);
  72 + res.end('Error.');
  73 +});
  74 +
60 75 console.info(`Forwarding API requests to http://${forwardHost}:${forwardPort}`);
  76 +console.info(`Forwarding Rule Node UI requests to http://${ruleNodeUiforwardHost}:${ruleNodeUiforwardPort}`);
61 77
62 78 app.all('/api/*', (req, res) => {
63 79 apiProxy.web(req, res);
64 80 });
65 81
  82 +app.all('/static/rulenode/*', (req, res) => {
  83 + ruleNodeUiApiProxy.web(req, res);
  84 +});
  85 +
66 86 app.get('*', function(req, res) {
67 87 res.sendFile(path.join(__dirname, 'src/index.html'));
68 88 });
... ...
... ... @@ -17,7 +17,7 @@ export default angular.module('thingsboard.api.ruleChain', [])
17 17 .factory('ruleChainService', RuleChainService).name;
18 18
19 19 /*@ngInject*/
20   -function RuleChainService($http, $q, $filter, types, componentDescriptorService) {
  20 +function RuleChainService($http, $q, $filter, $ocLazyLoad, $translate, types, componentDescriptorService) {
21 21
22 22 var ruleNodeComponents = null;
23 23
... ... @@ -177,11 +177,18 @@ function RuleChainService($http, $q, $filter, types, componentDescriptorService)
177 177 } else {
178 178 loadRuleNodeComponents().then(
179 179 (components) => {
180   - ruleNodeComponents = components;
181   - ruleNodeComponents.push(
182   - types.ruleChainNodeComponent
  180 + resolveRuleNodeComponentsUiResources(components).then(
  181 + (components) => {
  182 + ruleNodeComponents = components;
  183 + ruleNodeComponents.push(
  184 + types.ruleChainNodeComponent
  185 + );
  186 + deferred.resolve(ruleNodeComponents);
  187 + },
  188 + () => {
  189 + deferred.reject();
  190 + }
183 191 );
184   - deferred.resolve(ruleNodeComponents);
185 192 },
186 193 () => {
187 194 deferred.reject();
... ... @@ -191,6 +198,48 @@ function RuleChainService($http, $q, $filter, types, componentDescriptorService)
191 198 return deferred.promise;
192 199 }
193 200
  201 + function resolveRuleNodeComponentsUiResources(components) {
  202 + var deferred = $q.defer();
  203 + var tasks = [];
  204 + for (var i=0;i<components.length;i++) {
  205 + var component = components[i];
  206 + tasks.push(resolveRuleNodeComponentUiResources(component));
  207 + }
  208 + $q.all(tasks).then(
  209 + (components) => {
  210 + deferred.resolve(components);
  211 + },
  212 + () => {
  213 + deferred.resolve(components);
  214 + }
  215 + );
  216 + return deferred.promise;
  217 + }
  218 +
  219 + function resolveRuleNodeComponentUiResources(component) {
  220 + var deferred = $q.defer();
  221 + var uiResources = component.configurationDescriptor.nodeDefinition.uiResources;
  222 + if (uiResources && uiResources.length) {
  223 + var tasks = [];
  224 + for (var i=0;i<uiResources.length;i++) {
  225 + var uiResource = uiResources[i];
  226 + tasks.push($ocLazyLoad.load(uiResource));
  227 + }
  228 + $q.all(tasks).then(
  229 + () => {
  230 + deferred.resolve(component);
  231 + },
  232 + () => {
  233 + component.configurationDescriptor.nodeDefinition.uiResourceLoadError = $translate.instant('rulenode.ui-resources-load-error');
  234 + deferred.resolve(component);
  235 + }
  236 + )
  237 + } else {
  238 + deferred.resolve(component);
  239 + }
  240 + return deferred.promise;
  241 + }
  242 +
194 243 function getRuleNodeComponentByClazz(clazz) {
195 244 var res = $filter('filter')(ruleNodeComponents, {clazz: clazz}, true);
196 245 if (res && res.length) {
... ...
... ... @@ -279,6 +279,23 @@ export default angular.module('thingsboard.types', [])
279 279 function: "function",
280 280 alarm: "alarm"
281 281 },
  282 + contentType: {
  283 + "JSON": {
  284 + value: "JSON",
  285 + name: "content-type.json",
  286 + code: "json"
  287 + },
  288 + "TEXT": {
  289 + value: "TEXT",
  290 + name: "content-type.text",
  291 + code: "text"
  292 + },
  293 + "BINARY": {
  294 + value: "BINARY",
  295 + name: "content-type.binary",
  296 + code: "text"
  297 + }
  298 + },
282 299 componentType: {
283 300 filter: "FILTER",
284 301 processor: "PROCESSOR",
... ... @@ -295,7 +312,8 @@ export default angular.module('thingsboard.types', [])
295 312 user: "USER",
296 313 dashboard: "DASHBOARD",
297 314 alarm: "ALARM",
298   - rulechain: "RULE_CHAIN"
  315 + rulechain: "RULE_CHAIN",
  316 + rulenode: "RULE_NODE"
299 317 },
300 318 aliasEntityType: {
301 319 current_customer: "CURRENT_CUSTOMER"
... ... @@ -388,6 +406,16 @@ export default angular.module('thingsboard.types', [])
388 406 name: "event.type-stats"
389 407 }
390 408 },
  409 + debugEventType: {
  410 + debugRuleNode: {
  411 + value: "DEBUG_RULE_NODE",
  412 + name: "event.type-debug-rule-node"
  413 + },
  414 + debugRuleChain: {
  415 + value: "DEBUG_RULE_CHAIN",
  416 + name: "event.type-debug-rule-chain"
  417 + }
  418 + },
391 419 extensionType: {
392 420 http: "HTTP",
393 421 mqtt: "MQTT",
... ...
... ... @@ -26,7 +26,7 @@ export default angular.module('thingsboard.directives.detailsSidenav', [])
26 26 .name;
27 27
28 28 /*@ngInject*/
29   -function DetailsSidenav($timeout) {
  29 +function DetailsSidenav($timeout, $mdUtil, $q, $animate) {
30 30
31 31 var linker = function (scope, element, attrs) {
32 32
... ... @@ -42,6 +42,63 @@ function DetailsSidenav($timeout) {
42 42 scope.isEdit = true;
43 43 }
44 44
  45 + var backdrop;
  46 + var previousContainerStyles;
  47 +
  48 + if (attrs.hasOwnProperty('tbEnableBackdrop')) {
  49 + backdrop = $mdUtil.createBackdrop(scope, "md-sidenav-backdrop md-opaque ng-enter");
  50 + element.on('$destroy', function() {
  51 + backdrop && backdrop.remove();
  52 + });
  53 + scope.$on('$destroy', function(){
  54 + backdrop && backdrop.remove();
  55 + });
  56 + scope.$watch('isOpen', updateIsOpen);
  57 + }
  58 +
  59 + function updateIsOpen(isOpen) {
  60 + backdrop[isOpen ? 'on' : 'off']('click', (ev)=>{
  61 + ev.preventDefault();
  62 + scope.isOpen = false;
  63 + scope.$apply();
  64 + });
  65 + var parent = element.parent();
  66 + var restorePositioning = updateContainerPositions(parent, isOpen);
  67 +
  68 + return $q.all([
  69 + isOpen && backdrop ? $animate.enter(backdrop, parent) : backdrop ?
  70 + $animate.leave(backdrop) : $q.when(true)
  71 + ]).then(function() {
  72 + restorePositioning && restorePositioning();
  73 + });
  74 + }
  75 +
  76 + function updateContainerPositions(parent, willOpen) {
  77 + var drawerEl = element[0];
  78 + var scrollTop = parent[0].scrollTop;
  79 + if (willOpen && scrollTop) {
  80 + previousContainerStyles = {
  81 + top: drawerEl.style.top,
  82 + bottom: drawerEl.style.bottom,
  83 + height: drawerEl.style.height
  84 + };
  85 + var positionStyle = {
  86 + top: scrollTop + 'px',
  87 + bottom: 'auto',
  88 + height: parent[0].clientHeight + 'px'
  89 + };
  90 + backdrop.css(positionStyle);
  91 + }
  92 + if (!willOpen && previousContainerStyles) {
  93 + return function() {
  94 + backdrop[0].style.top = null;
  95 + backdrop[0].style.bottom = null;
  96 + backdrop[0].style.height = null;
  97 + previousContainerStyles = null;
  98 + };
  99 + }
  100 + }
  101 +
45 102 scope.toggleDetailsEditMode = function () {
46 103 if (!scope.isAlwaysEdit) {
47 104 if (!scope.isEdit) {
... ...
... ... @@ -16,7 +16,7 @@
16 16
17 17 -->
18 18 <md-sidenav class="md-sidenav-right md-whiteframe-4dp tb-sidenav-details"
19   - md-disable-backdrop="true"
  19 + md-disable-backdrop
20 20 md-is-open="isOpen"
21 21 md-component-id="right"
22 22 layout="column">
... ...
... ... @@ -43,6 +43,7 @@ function JsFunc($compile, $templateCache, toast, utils, $translate) {
43 43 var template = $templateCache.get(jsFuncTemplate);
44 44 element.html(template);
45 45
  46 + scope.functionName = attrs.functionName;
46 47 scope.functionArgs = scope.$eval(attrs.functionArgs);
47 48 scope.validationArgs = scope.$eval(attrs.validationArgs);
48 49 scope.resultType = attrs.resultType;
... ... @@ -50,6 +51,8 @@ function JsFunc($compile, $templateCache, toast, utils, $translate) {
50 51 scope.resultType = "nocheck";
51 52 }
52 53
  54 + scope.validationTriggerArg = attrs.validationTriggerArg;
  55 +
53 56 scope.functionValid = true;
54 57
55 58 var Range = ace.acequire("ace/range").Range;
... ... @@ -66,11 +69,15 @@ function JsFunc($compile, $templateCache, toast, utils, $translate) {
66 69 }
67 70
68 71 scope.onFullscreenChanged = function () {
  72 + updateEditorSize();
  73 + };
  74 +
  75 + function updateEditorSize() {
69 76 if (scope.js_editor) {
70 77 scope.js_editor.resize();
71 78 scope.js_editor.renderer.updateFull();
72 79 }
73   - };
  80 + }
74 81
75 82 scope.jsEditorOptions = {
76 83 useWrapMode: true,
... ... @@ -131,6 +138,9 @@ function JsFunc($compile, $templateCache, toast, utils, $translate) {
131 138 scope.validate = function () {
132 139 try {
133 140 var toValidate = new Function(scope.functionArgsString, scope.functionBody);
  141 + if (scope.noValidate) {
  142 + return true;
  143 + }
134 144 var res;
135 145 var validationError;
136 146 for (var i=0;i<scope.validationArgs.length;i++) {
... ... @@ -200,9 +210,19 @@ function JsFunc($compile, $templateCache, toast, utils, $translate) {
200 210 }
201 211 };
202 212
203   - scope.$on('form-submit', function () {
204   - scope.functionValid = scope.validate();
205   - scope.updateValidity();
  213 + scope.$on('form-submit', function (event, args) {
  214 + if (!args || scope.validationTriggerArg && scope.validationTriggerArg == args) {
  215 + scope.validationArgs = scope.$eval(attrs.validationArgs);
  216 + scope.cleanupJsErrors();
  217 + scope.functionValid = true;
  218 + scope.updateValidity();
  219 + scope.functionValid = scope.validate();
  220 + scope.updateValidity();
  221 + }
  222 + });
  223 +
  224 + scope.$on('update-ace-editor-size', function () {
  225 + updateEditorSize();
206 226 });
207 227
208 228 $compile(element.contents())(scope);
... ... @@ -211,7 +231,11 @@ function JsFunc($compile, $templateCache, toast, utils, $translate) {
211 231 return {
212 232 restrict: "E",
213 233 require: "^ngModel",
214   - scope: {},
  234 + scope: {
  235 + disabled:'=ngDisabled',
  236 + noValidate: '=?',
  237 + fillHeight:'=?'
  238 + },
215 239 link: linker
216 240 };
217 241 }
... ...
... ... @@ -15,6 +15,12 @@
15 15 */
16 16 tb-js-func {
17 17 position: relative;
  18 + .tb-disabled {
  19 + color: rgba(0,0,0,0.38);
  20 + }
  21 + .fill-height {
  22 + height: 100%;
  23 + }
18 24 }
19 25
20 26 .tb-js-func-panel {
... ... @@ -23,8 +29,10 @@ tb-js-func {
23 29 height: 100%;
24 30 #tb-javascript-input {
25 31 min-width: 200px;
26   - min-height: 200px;
27 32 width: 100%;
28 33 height: 100%;
  34 + &:not(.fill-height) {
  35 + min-height: 200px;
  36 + }
29 37 }
30 38 }
... ...
... ... @@ -15,19 +15,20 @@
15 15 limitations under the License.
16 16
17 17 -->
18   -<div style="background: #fff;" tb-expand-fullscreen fullscreen-zindex="100" expand-button-id="expand-button" on-fullscreen-changed="onFullscreenChanged()" layout="column">
  18 +<div style="background: #fff;" ng-class="{'tb-disabled': disabled, 'fill-height': fillHeight}" tb-expand-fullscreen fullscreen-zindex="100" expand-button-id="expand-button" on-fullscreen-changed="onFullscreenChanged()" layout="column">
19 19 <div layout="row" layout-align="start center" style="height: 40px;">
20   - <span style="font-style: italic;">function({{ functionArgsString }}) {</span>
  20 + <label class="tb-title no-padding">function {{ functionName }}({{ functionArgsString }}) {</label>
21 21 <span flex></span>
22 22 <div id="expand-button" layout="column" aria-label="Fullscreen" class="md-button md-icon-button tb-md-32 tb-fullscreen-button-style"></div>
23 23 </div>
24 24 <div flex id="tb-javascript-panel" class="tb-js-func-panel" layout="column">
25   - <div flex id="tb-javascript-input"
26   - ui-ace="jsEditorOptions"
  25 + <div flex id="tb-javascript-input" ng-class="{'fill-height': fillHeight}"
  26 + ui-ace="jsEditorOptions"
  27 + ng-readonly="disabled"
27 28 ng-model="functionBody">
28 29 </div>
29 30 </div>
30 31 <div layout="row" layout-align="start center" style="height: 40px;">
31   - <span style="font-style: italic;">}</span>
32   - </div>
33   -</div>
\ No newline at end of file
  32 + <label class="tb-title no-padding">}</label>
  33 + </div>
  34 +</div>
... ...
... ... @@ -84,17 +84,32 @@ function JsonObjectEdit($compile, $templateCache, $document, toast, utils) {
84 84 scope.$watch('contentBody', function (newVal, prevVal) {
85 85 if (!angular.equals(newVal, prevVal)) {
86 86 var object = scope.validate();
87   - ngModelCtrl.$setViewValue(object);
  87 + if (scope.objectValid) {
  88 + if (object == null) {
  89 + scope.object = null;
  90 + } else {
  91 + if (scope.object == null) {
  92 + scope.object = {};
  93 + }
  94 + Object.keys(scope.object).forEach(function (key) {
  95 + delete scope.object[key];
  96 + });
  97 + Object.keys(object).forEach(function (key) {
  98 + scope.object[key] = object[key];
  99 + });
  100 + }
  101 + ngModelCtrl.$setViewValue(scope.object);
  102 + }
88 103 scope.updateValidity();
89 104 }
90 105 });
91 106
92 107 ngModelCtrl.$render = function () {
93   - var object = ngModelCtrl.$viewValue;
  108 + scope.object = ngModelCtrl.$viewValue;
94 109 var content = '';
95 110 try {
96   - if (object) {
97   - content = angular.toJson(object, true);
  111 + if (scope.object) {
  112 + content = angular.toJson(scope.object, true);
98 113 }
99 114 } catch (e) {
100 115 //
... ...
... ... @@ -17,11 +17,14 @@ import $ from 'jquery';
17 17 import 'brace/ext/language_tools';
18 18 import 'brace/mode/java';
19 19 import 'brace/theme/github';
  20 +import beautify from 'js-beautify';
20 21
21 22 /* eslint-disable angular/angularelement */
22 23
  24 +const js_beautify = beautify.js;
  25 +
23 26 /*@ngInject*/
24   -export default function EventContentDialogController($mdDialog, content, title, showingCallback) {
  27 +export default function EventContentDialogController($mdDialog, types, content, contentType, title, showingCallback) {
25 28
26 29 var vm = this;
27 30
... ... @@ -32,9 +35,19 @@ export default function EventContentDialogController($mdDialog, content, title,
32 35 vm.content = content;
33 36 vm.title = title;
34 37
  38 + var mode;
  39 + if (contentType) {
  40 + mode = types.contentType[contentType].code;
  41 + if (contentType == types.contentType.JSON.value && vm.content) {
  42 + vm.content = js_beautify(vm.content, {indent_size: 4});
  43 + }
  44 + } else {
  45 + mode = 'java';
  46 + }
  47 +
35 48 vm.contentOptions = {
36 49 useWrapMode: false,
37   - mode: 'java',
  50 + mode: mode,
38 51 showGutter: false,
39 52 showPrintMargin: false,
40 53 theme: 'github',
... ...
  1 +<!--
  2 +
  3 + Copyright © 2016-2018 The Thingsboard Authors
  4 +
  5 + Licensed under the Apache License, Version 2.0 (the "License");
  6 + you may not use this file except in compliance with the License.
  7 + You may obtain a copy of the License at
  8 +
  9 + http://www.apache.org/licenses/LICENSE-2.0
  10 +
  11 + Unless required by applicable law or agreed to in writing, software
  12 + distributed under the License is distributed on an "AS IS" BASIS,
  13 + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  14 + See the License for the specific language governing permissions and
  15 + limitations under the License.
  16 +
  17 +-->
  18 +<div hide-xs hide-sm translate class="tb-cell" flex="30">event.event-time</div>
  19 +<div translate class="tb-cell" flex="20">event.server</div>
  20 +<div translate class="tb-cell" flex="20">event.type</div>
  21 +<div translate class="tb-cell" flex="20">event.entity</div>
  22 +<div translate class="tb-cell" flex="20">event.message-id</div>
  23 +<div translate class="tb-cell" flex="20">event.message-type</div>
  24 +<div translate class="tb-cell" flex="20">event.data-type</div>
  25 +<div translate class="tb-cell" flex="20">event.data</div>
  26 +<div translate class="tb-cell" flex="20">event.metadata</div>
  27 +<div translate class="tb-cell" flex="20">event.error</div>
... ...
... ... @@ -18,6 +18,7 @@
18 18 import eventHeaderLcEventTemplate from './event-header-lc-event.tpl.html';
19 19 import eventHeaderStatsTemplate from './event-header-stats.tpl.html';
20 20 import eventHeaderErrorTemplate from './event-header-error.tpl.html';
  21 +import eventHeaderDebugRuleNodeTemplate from './event-header-debug-rulenode.tpl.html';
21 22
22 23 /* eslint-enable import/no-unresolved, import/default */
23 24
... ... @@ -38,6 +39,12 @@ export default function EventHeaderDirective($compile, $templateCache, types) {
38 39 case types.eventType.error.value:
39 40 template = eventHeaderErrorTemplate;
40 41 break;
  42 + case types.debugEventType.debugRuleNode.value:
  43 + template = eventHeaderDebugRuleNodeTemplate;
  44 + break;
  45 + case types.debugEventType.debugRuleChain.value:
  46 + template = eventHeaderDebugRuleNodeTemplate;
  47 + break;
41 48 }
42 49 return $templateCache.get(template);
43 50 }
... ...
  1 +<!--
  2 +
  3 + Copyright © 2016-2018 The Thingsboard Authors
  4 +
  5 + Licensed under the Apache License, Version 2.0 (the "License");
  6 + you may not use this file except in compliance with the License.
  7 + You may obtain a copy of the License at
  8 +
  9 + http://www.apache.org/licenses/LICENSE-2.0
  10 +
  11 + Unless required by applicable law or agreed to in writing, software
  12 + distributed under the License is distributed on an "AS IS" BASIS,
  13 + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  14 + See the License for the specific language governing permissions and
  15 + limitations under the License.
  16 +
  17 +-->
  18 +<div hide-xs hide-sm class="tb-cell" flex="30">{{event.createdTime | date : 'yyyy-MM-dd HH:mm:ss'}}</div>
  19 +<div class="tb-cell" flex="20">{{event.body.server}}</div>
  20 +<div class="tb-cell" flex="20">{{event.body.type}}</div>
  21 +<div class="tb-cell" flex="20">{{event.body.entityName}}</div>
  22 +<div class="tb-cell" flex="20">{{event.body.msgId}}</div>
  23 +<div class="tb-cell" flex="20">{{event.body.msgType}}</div>
  24 +<div class="tb-cell" flex="20">{{event.body.dataType}}</div>
  25 +<div class="tb-cell" flex="20">
  26 + <md-button ng-if="event.body.data" class="md-icon-button md-primary"
  27 + ng-click="showContent($event, event.body.data, 'event.data', event.body.msgType)"
  28 + aria-label="{{ 'action.view' | translate }}">
  29 + <md-tooltip md-direction="top">
  30 + {{ 'action.view' | translate }}
  31 + </md-tooltip>
  32 + <md-icon aria-label="{{ 'action.view' | translate }}"
  33 + class="material-icons">
  34 + more_horiz
  35 + </md-icon>
  36 + </md-button>
  37 +</div>
  38 +<div class="tb-cell" flex="20">
  39 + <md-button ng-if="event.body.metadata" class="md-icon-button md-primary"
  40 + ng-click="showContent($event, event.body.metadata, 'event.metadata', 'JSON')"
  41 + aria-label="{{ 'action.view' | translate }}">
  42 + <md-tooltip md-direction="top">
  43 + {{ 'action.view' | translate }}
  44 + </md-tooltip>
  45 + <md-icon aria-label="{{ 'action.view' | translate }}"
  46 + class="material-icons">
  47 + more_horiz
  48 + </md-icon>
  49 + </md-button>
  50 +</div>
  51 +<div class="tb-cell" flex="20">
  52 + <md-button ng-if="event.body.error" class="md-icon-button md-primary"
  53 + ng-click="showContent($event, event.body.error, 'event.error')"
  54 + aria-label="{{ 'action.view' | translate }}">
  55 + <md-tooltip md-direction="top">
  56 + {{ 'action.view' | translate }}
  57 + </md-tooltip>
  58 + <md-icon aria-label="{{ 'action.view' | translate }}"
  59 + class="material-icons">
  60 + more_horiz
  61 + </md-icon>
  62 + </md-button>
  63 +</div>
... ...
... ... @@ -20,6 +20,7 @@ import eventErrorDialogTemplate from './event-content-dialog.tpl.html';
20 20 import eventRowLcEventTemplate from './event-row-lc-event.tpl.html';
21 21 import eventRowStatsTemplate from './event-row-stats.tpl.html';
22 22 import eventRowErrorTemplate from './event-row-error.tpl.html';
  23 +import eventRowDebugRuleNodeTemplate from './event-row-debug-rulenode.tpl.html';
23 24
24 25 /* eslint-enable import/no-unresolved, import/default */
25 26
... ... @@ -40,6 +41,12 @@ export default function EventRowDirective($compile, $templateCache, $mdDialog, $
40 41 case types.eventType.error.value:
41 42 template = eventRowErrorTemplate;
42 43 break;
  44 + case types.debugEventType.debugRuleNode.value:
  45 + template = eventRowDebugRuleNodeTemplate;
  46 + break;
  47 + case types.debugEventType.debugRuleChain.value:
  48 + template = eventRowDebugRuleNodeTemplate;
  49 + break;
43 50 }
44 51 return $templateCache.get(template);
45 52 }
... ... @@ -53,17 +60,22 @@ export default function EventRowDirective($compile, $templateCache, $mdDialog, $
53 60 scope.loadTemplate();
54 61 });
55 62
  63 + scope.types = types;
  64 +
56 65 scope.event = attrs.event;
57 66
58   - scope.showContent = function($event, content, title) {
  67 + scope.showContent = function($event, content, title, contentType) {
59 68 var onShowingCallback = {
60 69 onShowing: function(){}
61 70 }
  71 + if (!contentType) {
  72 + contentType = null;
  73 + }
62 74 $mdDialog.show({
63 75 controller: 'EventContentDialogController',
64 76 controllerAs: 'vm',
65 77 templateUrl: eventErrorDialogTemplate,
66   - locals: {content: content, title: title, showingCallback: onShowingCallback},
  78 + locals: {content: content, title: title, contentType: contentType, showingCallback: onShowingCallback},
67 79 parent: angular.element($document[0].body),
68 80 fullscreen: true,
69 81 targetEvent: $event,
... ...
... ... @@ -36,8 +36,8 @@ export default function EventTableDirective($compile, $templateCache, $rootScope
36 36 for (var type in types.eventType) {
37 37 var eventType = types.eventType[type];
38 38 var enabled = true;
39   - for (var disabledType in disabledEventTypes) {
40   - if (eventType.value === disabledEventTypes[disabledType]) {
  39 + for (var i=0;i<disabledEventTypes.length;i++) {
  40 + if (eventType.value === disabledEventTypes[i]) {
41 41 enabled = false;
42 42 break;
43 43 }
... ... @@ -47,7 +47,19 @@ export default function EventTableDirective($compile, $templateCache, $rootScope
47 47 }
48 48 }
49 49 } else {
50   - scope.eventTypes = types.eventType;
  50 + scope.eventTypes = angular.copy(types.eventType);
  51 + }
  52 +
  53 + if (attrs.debugEventTypes) {
  54 + var debugEventTypes = attrs.debugEventTypes.split(',');
  55 + for (i=0;i<debugEventTypes.length;i++) {
  56 + for (type in types.debugEventType) {
  57 + eventType = types.debugEventType[type];
  58 + if (eventType.value === debugEventTypes[i]) {
  59 + scope.eventTypes[type] = eventType;
  60 + }
  61 + }
  62 + }
51 63 }
52 64
53 65 scope.eventType = attrs.defaultEventType;
... ...
... ... @@ -341,6 +341,11 @@ export default angular.module('thingsboard.locale', [])
341 341 "enter-password": "Enter password",
342 342 "enter-search": "Enter search"
343 343 },
  344 + "content-type": {
  345 + "json": "Json",
  346 + "text": "Text",
  347 + "binary": "Binary (Base64)"
  348 + },
344 349 "customer": {
345 350 "customer": "Customer",
346 351 "customers": "Customers",
... ... @@ -762,6 +767,8 @@ export default angular.module('thingsboard.locale', [])
762 767 "type-error": "Error",
763 768 "type-lc-event": "Lifecycle event",
764 769 "type-stats": "Statistics",
  770 + "type-debug-rule-node": "Debug",
  771 + "type-debug-rule-chain": "Debug",
765 772 "no-events-prompt": "No events found",
766 773 "error": "Error",
767 774 "alarm": "Alarm",
... ... @@ -769,6 +776,13 @@ export default angular.module('thingsboard.locale', [])
769 776 "server": "Server",
770 777 "body": "Body",
771 778 "method": "Method",
  779 + "type": "Type",
  780 + "entity": "Entity",
  781 + "message-id": "Message Id",
  782 + "message-type": "Message Type",
  783 + "data-type": "Data Type",
  784 + "metadata": "Metadata",
  785 + "data": "Data",
772 786 "event": "Event",
773 787 "status": "Status",
774 788 "success": "Success",
... ... @@ -1171,6 +1185,8 @@ export default angular.module('thingsboard.locale', [])
1171 1185 "debug-mode": "Debug mode"
1172 1186 },
1173 1187 "rulenode": {
  1188 + "details": "Details",
  1189 + "events": "Events",
1174 1190 "add": "Add rule node",
1175 1191 "name": "Name",
1176 1192 "name-required": "Name is required.",
... ... @@ -1198,7 +1214,9 @@ export default angular.module('thingsboard.locale', [])
1198 1214 "type-action": "Action",
1199 1215 "type-action-details": "Perform special action",
1200 1216 "type-rule-chain": "Rule Chain",
1201   - "type-rule-chain-details": "Forwards incoming messages to specified Rule Chain"
  1217 + "type-rule-chain-details": "Forwards incoming messages to specified Rule Chain",
  1218 + "directive-is-not-loaded": "Defined configuration directive '{{directiveName}}' is not available.",
  1219 + "ui-resources-load-error": "Failed to load configuration ui resources."
1202 1220 },
1203 1221 "rule-plugin": {
1204 1222 "management": "Rules and plugins management"
... ...
... ... @@ -18,6 +18,8 @@ import RuleChainRoutes from './rulechain.routes';
18 18 import RuleChainsController from './rulechains.controller';
19 19 import {RuleChainController, AddRuleNodeController, AddRuleNodeLinkController} from './rulechain.controller';
20 20 import RuleChainDirective from './rulechain.directive';
  21 +import RuleNodeDefinedConfigDirective from './rulenode-defined-config.directive';
  22 +import RuleNodeConfigDirective from './rulenode-config.directive';
21 23 import RuleNodeDirective from './rulenode.directive';
22 24 import LinkDirective from './link.directive';
23 25
... ... @@ -28,6 +30,8 @@ export default angular.module('thingsboard.ruleChain', [])
28 30 .controller('AddRuleNodeController', AddRuleNodeController)
29 31 .controller('AddRuleNodeLinkController', AddRuleNodeLinkController)
30 32 .directive('tbRuleChain', RuleChainDirective)
  33 + .directive('tbRuleNodeDefinedConfig', RuleNodeDefinedConfigDirective)
  34 + .directive('tbRuleNodeConfig', RuleNodeConfigDirective)
31 35 .directive('tbRuleNode', RuleNodeDirective)
32 36 .directive('tbRuleNodeLink', LinkDirective)
33 37 .name;
... ...
... ... @@ -28,7 +28,7 @@ import addRuleNodeLinkTemplate from './add-link.tpl.html';
28 28 /* eslint-enable import/no-unresolved, import/default */
29 29
30 30 /*@ngInject*/
31   -export function RuleChainController($stateParams, $scope, $compile, $q, $mdUtil, $timeout, $mdExpansionPanel, $document, $mdDialog,
  31 +export function RuleChainController($stateParams, $scope, $compile, $q, $mdUtil, $timeout, $mdExpansionPanel, $window, $document, $mdDialog,
32 32 $filter, $translate, hotkeys, types, ruleChainService, Modelfactory, flowchartConstants,
33 33 ruleChain, ruleChainMetaData, ruleNodeComponents) {
34 34
... ... @@ -77,6 +77,8 @@ export function RuleChainController($stateParams, $scope, $compile, $q, $mdUtil,
77 77 vm.objectsSelected = objectsSelected;
78 78 vm.deleteSelected = deleteSelected;
79 79
  80 + vm.triggerResize = triggerResize;
  81 +
80 82 initHotKeys();
81 83
82 84 function initHotKeys() {
... ... @@ -129,23 +131,24 @@ export function RuleChainController($stateParams, $scope, $compile, $q, $mdUtil,
129 131 }
130 132
131 133 vm.onEditRuleNodeClosed = function() {
132   - vm.editingRuleNode = null;
  134 + //vm.editingRuleNode = null;
133 135 };
134 136
135 137 vm.onEditRuleNodeLinkClosed = function() {
136   - vm.editingRuleNodeLink = null;
  138 + //vm.editingRuleNodeLink = null;
137 139 };
138 140
139 141 vm.saveRuleNode = function(theForm) {
140   - theForm.$setPristine();
141   - vm.isEditingRuleNode = false;
142   - vm.ruleChainModel.nodes[vm.editingRuleNodeIndex] = vm.editingRuleNode;
143   - vm.editingRuleNode = angular.copy(vm.editingRuleNode);
  142 + $scope.$broadcast('form-submit');
  143 + if (theForm.$valid) {
  144 + theForm.$setPristine();
  145 + vm.ruleChainModel.nodes[vm.editingRuleNodeIndex] = vm.editingRuleNode;
  146 + vm.editingRuleNode = angular.copy(vm.editingRuleNode);
  147 + }
144 148 };
145 149
146 150 vm.saveRuleNodeLink = function(theForm) {
147 151 theForm.$setPristine();
148   - vm.isEditingRuleNodeLink = false;
149 152 vm.ruleChainModel.edges[vm.editingRuleNodeLinkIndex] = vm.editingRuleNodeLink;
150 153 vm.editingRuleNodeLink = angular.copy(vm.editingRuleNodeLink);
151 154 };
... ... @@ -253,6 +256,9 @@ export function RuleChainController($stateParams, $scope, $compile, $q, $mdUtil,
253 256 vm.isEditingRuleNodeLink = true;
254 257 vm.editingRuleNodeLinkIndex = vm.ruleChainModel.edges.indexOf(edge);
255 258 vm.editingRuleNodeLink = angular.copy(edge);
  259 + $mdUtil.nextTick(() => {
  260 + vm.ruleNodeLinkForm.$setPristine();
  261 + });
256 262 }
257 263 },
258 264 nodeCallbacks: {
... ... @@ -263,6 +269,9 @@ export function RuleChainController($stateParams, $scope, $compile, $q, $mdUtil,
263 269 vm.isEditingRuleNode = true;
264 270 vm.editingRuleNodeIndex = vm.ruleChainModel.nodes.indexOf(node);
265 271 vm.editingRuleNode = angular.copy(node);
  272 + $mdUtil.nextTick(() => {
  273 + vm.ruleNodeForm.$setPristine();
  274 + });
266 275 }
267 276 }
268 277 },
... ... @@ -309,7 +318,7 @@ export function RuleChainController($stateParams, $scope, $compile, $q, $mdUtil,
309 318 var componentType = ruleNodeComponent.type;
310 319 var model = vm.ruleNodeTypesModel[componentType].model;
311 320 var node = {
312   - id: model.nodes.length,
  321 + id: 'node-lib-' + componentType + '-' + model.nodes.length,
313 322 component: ruleNodeComponent,
314 323 name: '',
315 324 nodeClass: vm.types.ruleNodeType[componentType].nodeClass,
... ... @@ -358,7 +367,7 @@ export function RuleChainController($stateParams, $scope, $compile, $q, $mdUtil,
358 367
359 368 vm.ruleChainModel.nodes.push(
360 369 {
361   - id: vm.nextNodeID++,
  370 + id: 'rule-chain-node-' + vm.nextNodeID++,
362 371 component: types.inputNodeComponent,
363 372 name: "",
364 373 nodeClass: types.ruleNodeType.INPUT.nodeClass,
... ... @@ -389,7 +398,7 @@ export function RuleChainController($stateParams, $scope, $compile, $q, $mdUtil,
389 398 var component = ruleChainService.getRuleNodeComponentByClazz(ruleNode.type);
390 399 if (component) {
391 400 var node = {
392   - id: vm.nextNodeID++,
  401 + id: 'rule-chain-node-' + vm.nextNodeID++,
393 402 ruleNodeId: ruleNode.id,
394 403 additionalInfo: ruleNode.additionalInfo,
395 404 configuration: ruleNode.configuration,
... ... @@ -466,7 +475,7 @@ export function RuleChainController($stateParams, $scope, $compile, $q, $mdUtil,
466 475 var ruleChainNode = ruleChainNodesMap[ruleChainConnection.additionalInfo.ruleChainNodeId];
467 476 if (!ruleChainNode) {
468 477 ruleChainNode = {
469   - id: vm.nextNodeID++,
  478 + id: 'rule-chain-node-' + vm.nextNodeID++,
470 479 additionalInfo: ruleChainConnection.additionalInfo,
471 480 targetRuleChainId: ruleChainConnection.targetRuleChainId.id,
472 481 x: ruleChainConnection.additionalInfo.layoutX,
... ... @@ -611,7 +620,7 @@ export function RuleChainController($stateParams, $scope, $compile, $q, $mdUtil,
611 620 fullscreen: true,
612 621 targetEvent: $event
613 622 }).then(function (ruleNode) {
614   - ruleNode.id = vm.nextNodeID++;
  623 + ruleNode.id = 'rule-chain-node-' + vm.nextNodeID++;
615 624 ruleNode.connectors = [];
616 625 if (ruleNode.component.configurationDescriptor.nodeDefinition.inEnabled) {
617 626 ruleNode.connectors.push(
... ... @@ -654,6 +663,11 @@ export function RuleChainController($stateParams, $scope, $compile, $q, $mdUtil,
654 663 function deleteSelected() {
655 664 vm.modelservice.deleteSelected();
656 665 }
  666 +
  667 + function triggerResize() {
  668 + var w = angular.element($window);
  669 + w.triggerHandler('resize');
  670 + }
657 671 }
658 672
659 673 /*@ngInject*/
... ...
... ... @@ -65,9 +65,11 @@
65 65 </div>
66 66 <tb-details-sidenav class="tb-rulenode-details-sidenav"
67 67 header-title="{{vm.editingRuleNode.name}}"
68   - header-subtitle="{{'rulenode.rulenode-details' | translate}}"
69   - is-read-only="false"
  68 + header-subtitle="{{(vm.types.ruleNodeType[vm.editingRuleNode.component.type].name | translate)
  69 + + ' - ' + vm.editingRuleNode.component.name}}"
  70 + is-read-only="vm.selectedRuleNodeTabIndex > 0"
70 71 is-open="vm.isEditingRuleNode"
  72 + tb-enable-backdrop
71 73 is-always-edit="true"
72 74 on-close-details="vm.onEditRuleNodeClosed()"
73 75 on-toggle-details-edit-mode="vm.onRevertRuleNodeEdit(vm.ruleNodeForm)"
... ... @@ -76,22 +78,37 @@
76 78 <details-buttons tb-help="vm.helpLinkIdForRuleNodeType()" help-container-id="help-container">
77 79 <div id="help-container"></div>
78 80 </details-buttons>
79   - <form name="vm.ruleNodeForm" ng-if="vm.isEditingRuleNode">
80   - <tb-rule-node
81   - rule-node="vm.editingRuleNode"
82   - rule-chain-id="vm.ruleChain.id.id"
83   - is-edit="true"
84   - is-read-only="false"
85   - on-delete-rule-node="vm.deleteRuleNode(event, vm.editingRuleNode)"
86   - the-form="vm.ruleNodeForm">
87   - </tb-rule-node>
88   - </form>
  81 + <md-tabs md-selected="vm.selectedRuleNodeTabIndex"
  82 + id="ruleNodeTabs" md-border-bottom flex class="tb-absolute-fill" ng-if="vm.isEditingRuleNode">
  83 + <md-tab label="{{ 'rulenode.details' | translate }}">
  84 + <form name="vm.ruleNodeForm">
  85 + <tb-rule-node
  86 + rule-node="vm.editingRuleNode"
  87 + rule-chain-id="vm.ruleChain.id.id"
  88 + is-edit="true"
  89 + is-read-only="false"
  90 + on-delete-rule-node="vm.deleteRuleNode(event, vm.editingRuleNode)"
  91 + the-form="vm.ruleNodeForm">
  92 + </tb-rule-node>
  93 + </form>
  94 + </md-tab>
  95 + <md-tab ng-if="vm.isEditingRuleNode && vm.editingRuleNode.ruleNodeId"
  96 + md-on-select="vm.triggerResize()" label="{{ 'rulenode.events' | translate }}">
  97 + <tb-event-table flex entity-type="vm.types.entityType.rulenode"
  98 + entity-id="vm.editingRuleNode.ruleNodeId.id"
  99 + tenant-id="vm.ruleChain.tenantId.id"
  100 + debug-event-types="{{vm.types.debugEventType.debugRuleNode.value}}"
  101 + default-event-type="{{vm.types.debugEventType.debugRuleNode.value}}">
  102 + </tb-event-table>
  103 + </md-tab>
  104 + </md-tabs>
89 105 </tb-details-sidenav>
90 106 <tb-details-sidenav class="tb-rulenode-link-details-sidenav"
91 107 header-title="{{vm.editingRuleNodeLink.label}}"
92 108 header-subtitle="{{'rulenode.link-details' | translate}}"
93 109 is-read-only="false"
94 110 is-open="vm.isEditingRuleNodeLink"
  111 + tb-enable-backdrop
95 112 is-always-edit="true"
96 113 on-close-details="vm.onEditRuleNodeLinkClosed()"
97 114 on-toggle-details-edit-mode="vm.onRevertRuleNodeLinkEdit(vm.ruleNodeLinkForm)"
... ...
... ... @@ -55,7 +55,8 @@
55 55 <tb-event-table flex entity-type="vm.types.entityType.rulechain"
56 56 entity-id="vm.grid.operatingItem().id.id"
57 57 tenant-id="vm.grid.operatingItem().tenantId.id"
58   - default-event-type="{{vm.types.eventType.lcEvent.value}}">
  58 + debug-event-types="{{vm.types.debugEventType.debugRuleChain.value}}"
  59 + default-event-type="{{vm.types.debugEventType.debugRuleChain.value}}">
59 60 </tb-event-table>
60 61 </md-tab>
61 62 <md-tab ng-if="!vm.grid.detailsConfig.isDetailsEditMode && vm.isRuleChainEditable(vm.grid.operatingItem())" md-on-select="vm.grid.triggerResize()" label="{{ 'relation.relations' | translate }}">
... ...
  1 +/*
  2 + * Copyright © 2016-2018 The Thingsboard Authors
  3 + *
  4 + * Licensed under the Apache License, Version 2.0 (the "License");
  5 + * you may not use this file except in compliance with the License.
  6 + * You may obtain a copy of the License at
  7 + *
  8 + * http://www.apache.org/licenses/LICENSE-2.0
  9 + *
  10 + * Unless required by applicable law or agreed to in writing, software
  11 + * distributed under the License is distributed on an "AS IS" BASIS,
  12 + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  13 + * See the License for the specific language governing permissions and
  14 + * limitations under the License.
  15 + */
  16 +
  17 +/* eslint-disable import/no-unresolved, import/default */
  18 +
  19 +import ruleNodeConfigTemplate from './rulenode-config.tpl.html';
  20 +
  21 +/* eslint-enable import/no-unresolved, import/default */
  22 +
  23 +/*@ngInject*/
  24 +export default function RuleNodeConfigDirective($compile, $templateCache, $injector, $translate) {
  25 +
  26 + var linker = function (scope, element, attrs, ngModelCtrl) {
  27 + var template = $templateCache.get(ruleNodeConfigTemplate);
  28 + element.html(template);
  29 +
  30 + scope.$watch('configuration', function (newVal, prevVal) {
  31 + if (!angular.equals(newVal, prevVal)) {
  32 + ngModelCtrl.$setViewValue(scope.configuration);
  33 + }
  34 + });
  35 +
  36 + ngModelCtrl.$render = function () {
  37 + scope.configuration = ngModelCtrl.$viewValue;
  38 + };
  39 +
  40 + scope.useDefinedDirective = function() {
  41 + return scope.nodeDefinition &&
  42 + scope.nodeDefinition.configDirective && !scope.definedDirectiveError;
  43 + };
  44 +
  45 + scope.$watch('nodeDefinition', () => {
  46 + if (scope.nodeDefinition) {
  47 + validateDefinedDirective();
  48 + }
  49 + });
  50 +
  51 + function validateDefinedDirective() {
  52 + if (scope.nodeDefinition.uiResourceLoadError && scope.nodeDefinition.uiResourceLoadError.length) {
  53 + scope.definedDirectiveError = scope.nodeDefinition.uiResourceLoadError;
  54 + } else {
  55 + var definedDirective = scope.nodeDefinition.configDirective;
  56 + if (definedDirective && definedDirective.length) {
  57 + if (!$injector.has(definedDirective + 'Directive')) {
  58 + scope.definedDirectiveError = $translate.instant('rulenode.directive-is-not-loaded', {directiveName: definedDirective});
  59 + }
  60 + }
  61 + }
  62 + }
  63 +
  64 + $compile(element.contents())(scope);
  65 + };
  66 +
  67 + return {
  68 + restrict: "E",
  69 + require: "^ngModel",
  70 + scope: {
  71 + nodeDefinition:'=',
  72 + required:'=ngRequired',
  73 + readonly:'=ngReadonly'
  74 + },
  75 + link: linker
  76 + };
  77 +
  78 +}
... ...
  1 +<!--
  2 +
  3 + Copyright © 2016-2018 The Thingsboard Authors
  4 +
  5 + Licensed under the Apache License, Version 2.0 (the "License");
  6 + you may not use this file except in compliance with the License.
  7 + You may obtain a copy of the License at
  8 +
  9 + http://www.apache.org/licenses/LICENSE-2.0
  10 +
  11 + Unless required by applicable law or agreed to in writing, software
  12 + distributed under the License is distributed on an "AS IS" BASIS,
  13 + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  14 + See the License for the specific language governing permissions and
  15 + limitations under the License.
  16 +
  17 +-->
  18 +
  19 +<tb-rule-node-defined-config ng-if="useDefinedDirective()"
  20 + ng-model="configuration"
  21 + rule-node-directive="{{nodeDefinition.configDirective}}"
  22 + ng-required="required"
  23 + ng-readonly="readonly">
  24 +</tb-rule-node-defined-config>
  25 +<div class="tb-rulenode-directive-error" ng-if="definedDirectiveError">{{definedDirectiveError}}</div>
  26 +<tb-json-object-edit ng-if="!useDefinedDirective()"
  27 + class="tb-rule-node-configuration-json"
  28 + ng-model="configuration"
  29 + label="{{ 'rulenode.configuration' | translate }}"
  30 + ng-required="required"
  31 + fill-height="true">
  32 +</tb-json-object-edit>
... ...
  1 +/*
  2 + * Copyright © 2016-2018 The Thingsboard Authors
  3 + *
  4 + * Licensed under the Apache License, Version 2.0 (the "License");
  5 + * you may not use this file except in compliance with the License.
  6 + * You may obtain a copy of the License at
  7 + *
  8 + * http://www.apache.org/licenses/LICENSE-2.0
  9 + *
  10 + * Unless required by applicable law or agreed to in writing, software
  11 + * distributed under the License is distributed on an "AS IS" BASIS,
  12 + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  13 + * See the License for the specific language governing permissions and
  14 + * limitations under the License.
  15 + */
  16 +
  17 +const SNAKE_CASE_REGEXP = /[A-Z]/g;
  18 +
  19 +/*@ngInject*/
  20 +export default function RuleNodeDefinedConfigDirective($compile) {
  21 +
  22 + var linker = function (scope, element, attrs, ngModelCtrl) {
  23 +
  24 + attrs.$observe('ruleNodeDirective', function() {
  25 + loadTemplate();
  26 + });
  27 +
  28 + scope.$watch('configuration', function (newVal, prevVal) {
  29 + if (!angular.equals(newVal, prevVal)) {
  30 + ngModelCtrl.$setViewValue(scope.configuration);
  31 + }
  32 + });
  33 +
  34 + ngModelCtrl.$render = function () {
  35 + scope.configuration = ngModelCtrl.$viewValue;
  36 + };
  37 +
  38 + function loadTemplate() {
  39 + if (scope.ruleNodeConfigScope) {
  40 + scope.ruleNodeConfigScope.$destroy();
  41 + }
  42 + var directive = snake_case(attrs.ruleNodeDirective, '-');
  43 + var template = `<${directive} ng-model="configuration" ng-required="required" ng-readonly="readonly"></${directive}>`;
  44 + element.html(template);
  45 + scope.ruleNodeConfigScope = scope.$new();
  46 + $compile(element.contents())(scope.ruleNodeConfigScope);
  47 + }
  48 +
  49 + function snake_case(name, separator) {
  50 + separator = separator || '_';
  51 + return name.replace(SNAKE_CASE_REGEXP, function(letter, pos) {
  52 + return (pos ? separator : '') + letter.toLowerCase();
  53 + });
  54 + }
  55 + };
  56 +
  57 + return {
  58 + restrict: "E",
  59 + require: "^ngModel",
  60 + scope: {
  61 + required:'=ngRequired',
  62 + readonly:'=ngReadonly'
  63 + },
  64 + link: linker
  65 + };
  66 +
  67 +}
... ...
... ... @@ -21,28 +21,26 @@
21 21
22 22 <md-content class="md-padding tb-rulenode" layout="column">
23 23 <fieldset ng-disabled="$root.loading || !isEdit || isReadOnly">
24   - <md-input-container class="md-block">
25   - <label translate>rulenode.type</label>
26   - <input readonly name="type" ng-model="ruleNode.component.name">
27   - </md-input-container>
28 24 <section ng-if="ruleNode.component.type != types.ruleNodeType.RULE_CHAIN.value">
29   - <md-input-container class="md-block">
30   - <label translate>rulenode.name</label>
31   - <input required name="name" ng-model="ruleNode.name">
32   - <div ng-messages="theForm.name.$error">
33   - <div translate ng-message="required">rulenode.name-required</div>
34   - </div>
35   - </md-input-container>
36   - <md-input-container class="md-block">
37   - <md-checkbox ng-disabled="$root.loading || !isEdit" aria-label="{{ 'rulenode.debug-mode' | translate }}"
38   - ng-model="ruleNode.debugMode">{{ 'rulenode.debug-mode' | translate }}
39   - </md-checkbox>
40   - </md-input-container>
41   - <tb-json-object-edit class="tb-rule-node-configuration-json" ng-model="ruleNode.configuration"
42   - label="{{ 'rulenode.configuration' | translate }}"
  25 + <section layout="column" layout-gt-sm="row">
  26 + <md-input-container flex class="md-block">
  27 + <label translate>rulenode.name</label>
  28 + <input required name="name" ng-model="ruleNode.name">
  29 + <div ng-messages="theForm.name.$error">
  30 + <div translate ng-message="required">rulenode.name-required</div>
  31 + </div>
  32 + </md-input-container>
  33 + <md-input-container class="md-block">
  34 + <md-checkbox ng-disabled="$root.loading || !isEdit" aria-label="{{ 'rulenode.debug-mode' | translate }}"
  35 + ng-model="ruleNode.debugMode">{{ 'rulenode.debug-mode' | translate }}
  36 + </md-checkbox>
  37 + </md-input-container>
  38 + </section>
  39 + <tb-rule-node-config ng-model="ruleNode.configuration"
43 40 ng-required="true"
44   - fill-height="true">
45   - </tb-json-object-edit>
  41 + node-definition="ruleNode.component.configurationDescriptor.nodeDefinition"
  42 + ng-readonly="$root.loading || !isEdit || isReadOnly">
  43 + </tb-rule-node-config>
46 44 <md-input-container class="md-block">
47 45 <label translate>rulenode.description</label>
48 46 <textarea ng-model="ruleNode.additionalInfo.description" rows="2"></textarea>
... ...
... ... @@ -19,4 +19,10 @@
19 19 height: 300px;
20 20 display: block;
21 21 }
  22 +}
  23 +
  24 +.tb-rulenode-directive-error {
  25 + color: rgb(221,44,0);
  26 + font-size: 13px;
  27 + font-weight: 400;
22 28 }
\ No newline at end of file
... ...