Commit 7604b78f0e0b5df6b9810f26dec60599a98eaf7d
Committed by
GitHub
Merge pull request #3405 from ShvaykaD/improvements/queue-reprocessing-strategy
[2.5.5] Improvements/queue reprocessing strategy
Showing
3 changed files
with
11 additions
and
1 deletions
... | ... | @@ -56,7 +56,9 @@ public class TbRuleEngineProcessingStrategyFactory { |
56 | 56 | private final boolean retryTimeout; |
57 | 57 | private final int maxRetries; |
58 | 58 | private final double maxAllowedFailurePercentage; |
59 | - private final long pauseBetweenRetries; | |
59 | + private final long maxPauseBetweenRetries; | |
60 | + | |
61 | + private long pauseBetweenRetries; | |
60 | 62 | |
61 | 63 | private int initialTotalCount; |
62 | 64 | private int retryCount; |
... | ... | @@ -69,6 +71,7 @@ public class TbRuleEngineProcessingStrategyFactory { |
69 | 71 | this.maxRetries = configuration.getRetries(); |
70 | 72 | this.maxAllowedFailurePercentage = configuration.getFailurePercentage(); |
71 | 73 | this.pauseBetweenRetries = configuration.getPauseBetweenRetries(); |
74 | + this.maxPauseBetweenRetries = configuration.getMaxPauseBetweenRetries(); | |
72 | 75 | } |
73 | 76 | |
74 | 77 | @Override |
... | ... | @@ -108,6 +111,9 @@ public class TbRuleEngineProcessingStrategyFactory { |
108 | 111 | } catch (InterruptedException e) { |
109 | 112 | throw new RuntimeException(e); |
110 | 113 | } |
114 | + if (maxPauseBetweenRetries > pauseBetweenRetries) { | |
115 | + pauseBetweenRetries = Math.min(maxPauseBetweenRetries, pauseBetweenRetries * 2); | |
116 | + } | |
111 | 117 | } |
112 | 118 | return new TbRuleEngineProcessingDecision(false, toReprocess); |
113 | 119 | } | ... | ... |
... | ... | @@ -729,6 +729,7 @@ queue: |
729 | 729 | retries: "${TB_QUEUE_RE_MAIN_PROCESSING_STRATEGY_RETRIES:3}" # Number of retries, 0 is unlimited |
730 | 730 | failure-percentage: "${TB_QUEUE_RE_MAIN_PROCESSING_STRATEGY_FAILURE_PERCENTAGE:0}" # Skip retry if failures or timeouts are less then X percentage of messages; |
731 | 731 | pause-between-retries: "${TB_QUEUE_RE_MAIN_PROCESSING_STRATEGY_RETRY_PAUSE:3}"# Time in seconds to wait in consumer thread before retries; |
732 | + max-pause-between-retries: "${TB_QUEUE_RE_MAIN_PROCESSING_STRATEGY_MAX_RETRY_PAUSE:3}"# Max allowed time in seconds for pause between retries. | |
732 | 733 | - name: "${TB_QUEUE_RE_HP_QUEUE_NAME:HighPriority}" |
733 | 734 | topic: "${TB_QUEUE_RE_HP_TOPIC:tb_rule_engine.hp}" |
734 | 735 | poll-interval: "${TB_QUEUE_RE_HP_POLL_INTERVAL_MS:25}" |
... | ... | @@ -744,6 +745,7 @@ queue: |
744 | 745 | retries: "${TB_QUEUE_RE_HP_PROCESSING_STRATEGY_RETRIES:0}" # Number of retries, 0 is unlimited |
745 | 746 | failure-percentage: "${TB_QUEUE_RE_HP_PROCESSING_STRATEGY_FAILURE_PERCENTAGE:0}" # Skip retry if failures or timeouts are less then X percentage of messages; |
746 | 747 | pause-between-retries: "${TB_QUEUE_RE_HP_PROCESSING_STRATEGY_RETRY_PAUSE:5}"# Time in seconds to wait in consumer thread before retries; |
748 | + max-pause-between-retries: "${TB_QUEUE_RE_HP_PROCESSING_STRATEGY_MAX_RETRY_PAUSE:5}"# Max allowed time in seconds for pause between retries. | |
747 | 749 | - name: "${TB_QUEUE_RE_SQ_QUEUE_NAME:SequentialByOriginator}" |
748 | 750 | topic: "${TB_QUEUE_RE_SQ_TOPIC:tb_rule_engine.sq}" |
749 | 751 | poll-interval: "${TB_QUEUE_RE_SQ_POLL_INTERVAL_MS:25}" |
... | ... | @@ -759,6 +761,7 @@ queue: |
759 | 761 | retries: "${TB_QUEUE_RE_SQ_PROCESSING_STRATEGY_RETRIES:3}" # Number of retries, 0 is unlimited |
760 | 762 | failure-percentage: "${TB_QUEUE_RE_SQ_PROCESSING_STRATEGY_FAILURE_PERCENTAGE:0}" # Skip retry if failures or timeouts are less then X percentage of messages; |
761 | 763 | pause-between-retries: "${TB_QUEUE_RE_SQ_PROCESSING_STRATEGY_RETRY_PAUSE:5}"# Time in seconds to wait in consumer thread before retries; |
764 | + max-pause-between-retries: "${TB_QUEUE_RE_SQ_PROCESSING_STRATEGY_MAX_RETRY_PAUSE:5}"# Max allowed time in seconds for pause between retries. | |
762 | 765 | transport: |
763 | 766 | # For high priority notifications that require minimum latency and processing time |
764 | 767 | notifications_topic: "${TB_QUEUE_TRANSPORT_NOTIFICATIONS_TOPIC:tb_transport.notifications}" | ... | ... |