Commit 05771cd900427f4bbedac9feb8b8d83a7d152084
1 parent
00caacf6
getEdge, getTenantEdges, getCustomerEdges refactored
Showing
4 changed files
with
31 additions
and
20 deletions
... | ... | @@ -30,6 +30,7 @@ function EdgeService($http, $q, customerService) { |
30 | 30 | getTenantEdges: getTenantEdges, |
31 | 31 | getCustomerEdges: getCustomerEdges, |
32 | 32 | assignEdgeToCustomer: assignEdgeToCustomer, |
33 | + findByQuery: findByQuery, | |
33 | 34 | unassignEdgeFromCustomer: unassignEdgeFromCustomer, |
34 | 35 | makeEdgePublic: makeEdgePublic, |
35 | 36 | setRootRuleChain: setRootRuleChain, |
... | ... | @@ -61,13 +62,7 @@ function EdgeService($http, $q, customerService) { |
61 | 62 | |
62 | 63 | function getEdgesByIds(edgeIds, config) { |
63 | 64 | var deferred = $q.defer(); |
64 | - var ids = ''; | |
65 | - for (var i=0;i<edgeIds.length;i++) { | |
66 | - if (i>0) { | |
67 | - ids += ','; | |
68 | - } | |
69 | - ids += edgeIds[i]; | |
70 | - } | |
65 | + var ids = edgeIds.join(','); | |
71 | 66 | var url = '/api/edges?edgeIds=' + ids; |
72 | 67 | $http.get(url, config).then(function success(response) { |
73 | 68 | var entities = response.data; |
... | ... | @@ -85,9 +80,13 @@ function EdgeService($http, $q, customerService) { |
85 | 80 | return deferred.promise; |
86 | 81 | } |
87 | 82 | |
88 | - function getEdge(edgeId, config) { | |
83 | + function getEdge(edgeId, ignoreErrors, config) { | |
89 | 84 | var deferred = $q.defer(); |
90 | 85 | var url = '/api/edge/' + edgeId; |
86 | + if (!config) { | |
87 | + config = {}; | |
88 | + } | |
89 | + config = Object.assign(config, { ignoreErrors: ignoreErrors }); | |
91 | 90 | $http.get(url, config).then(function success(response) { |
92 | 91 | deferred.resolve(response.data); |
93 | 92 | }, function fail(response) { |
... | ... | @@ -129,7 +128,7 @@ function EdgeService($http, $q, customerService) { |
129 | 128 | return deferred.promise; |
130 | 129 | } |
131 | 130 | |
132 | - function getTenantEdges(pageLink, applyCustomersInfo, config, type) { | |
131 | + function getTenantEdges(pageLink, applyCustomersInfo, type, config) { | |
133 | 132 | var deferred = $q.defer(); |
134 | 133 | var url = '/api/tenant/edges?limit=' + pageLink.limit; |
135 | 134 | if (angular.isDefined(pageLink.textSearch)) { |
... | ... | @@ -164,7 +163,7 @@ function EdgeService($http, $q, customerService) { |
164 | 163 | return deferred.promise; |
165 | 164 | } |
166 | 165 | |
167 | - function getCustomerEdges(customerId, pageLink, applyCustomersInfo, config, type) { | |
166 | + function getCustomerEdges(customerId, pageLink, applyCustomersInfo, type, config) { | |
168 | 167 | var deferred = $q.defer(); |
169 | 168 | var url = '/api/customer/' + customerId + '/edges?limit=' + pageLink.limit; |
170 | 169 | if (angular.isDefined(pageLink.textSearch)) { |
... | ... | @@ -200,6 +199,21 @@ function EdgeService($http, $q, customerService) { |
200 | 199 | return deferred.promise; |
201 | 200 | } |
202 | 201 | |
202 | + function findByQuery(query, ignoreErrors, config) { | |
203 | + var deferred = $q.defer(); | |
204 | + var url = '/api/edges'; | |
205 | + if (!config) { | |
206 | + config = {}; | |
207 | + } | |
208 | + config = Object.assign(config, { ignoreErrors: ignoreErrors }); | |
209 | + $http.post(url, query, config).then(function success(response) { | |
210 | + deferred.resolve(response.data); | |
211 | + }, function fail() { | |
212 | + deferred.reject(); | |
213 | + }); | |
214 | + return deferred.promise; | |
215 | + } | |
216 | + | |
203 | 217 | function assignEdgeToCustomer(customerId, edgeId) { |
204 | 218 | var deferred = $q.defer(); |
205 | 219 | var url = '/api/customer/' + customerId + '/edge/' + edgeId; | ... | ... |
... | ... | @@ -78,7 +78,7 @@ function EntityService($http, $q, $filter, $translate, $log, userService, device |
78 | 78 | $log.error('Get Alarm Entity is not implemented!'); |
79 | 79 | break; |
80 | 80 | case types.entityType.edge: |
81 | - promise = edgeService.getEdge(entityId, config); | |
81 | + promise = edgeService.getEdge(entityId, true, config); | |
82 | 82 | break; |
83 | 83 | } |
84 | 84 | return promise; |
... | ... | @@ -164,7 +164,7 @@ function EntityService($http, $q, $filter, $translate, $log, userService, device |
164 | 164 | break; |
165 | 165 | case types.entityType.edge: |
166 | 166 | promise = getEntitiesByIdsPromise( |
167 | - (id) => edgeService.getEdge(id, config), entityIds); | |
167 | + (id) => edgeService.getEdge(id, true, config), entityIds); | |
168 | 168 | break; |
169 | 169 | } |
170 | 170 | return promise; |
... | ... | @@ -294,9 +294,9 @@ function EntityService($http, $q, $filter, $translate, $log, userService, device |
294 | 294 | break; |
295 | 295 | case types.entityType.edge: |
296 | 296 | if (user.authority === 'CUSTOMER_USER') { |
297 | - promise = edgeService.getCustomerEdges(customerId, pageLink, false, config, subType); | |
297 | + promise = edgeService.getCustomerEdges(customerId, pageLink, false, subType, config); | |
298 | 298 | } else { |
299 | - promise = edgeService.getTenantEdges(pageLink, false, config, subType); | |
299 | + promise = edgeService.getTenantEdges(pageLink, false, subType, config); | |
300 | 300 | } |
301 | 301 | break; |
302 | 302 | } |
... | ... | @@ -960,9 +960,6 @@ function EntityService($http, $q, $filter, $translate, $log, userService, device |
960 | 960 | break; |
961 | 961 | case types.entityType.entityView: |
962 | 962 | case types.entityType.edge: |
963 | - entityFieldKeys.push(types.entityField.name.keyName); | |
964 | - entityFieldKeys.push(types.entityField.type.keyName); | |
965 | - break; | |
966 | 963 | case types.entityType.device: |
967 | 964 | case types.entityType.asset: |
968 | 965 | entityFieldKeys.push(types.entityField.name.keyName); | ... | ... |
... | ... | @@ -161,7 +161,7 @@ export function EdgeController($rootScope, userService, edgeService, customerSer |
161 | 161 | |
162 | 162 | if (vm.edgesScope === 'tenant') { |
163 | 163 | fetchEdgesFunction = function (pageLink, edgeType) { |
164 | - return edgeService.getTenantEdges(pageLink, true, null, edgeType); | |
164 | + return edgeService.getTenantEdges(pageLink, true, edgeType, null); | |
165 | 165 | }; |
166 | 166 | deleteEdgeFunction = function (edgeId) { |
167 | 167 | return edgeService.deleteEdge(edgeId); |
... | ... | @@ -337,7 +337,7 @@ export function EdgeController($rootScope, userService, edgeService, customerSer |
337 | 337 | |
338 | 338 | } else if (vm.edgesScope === 'customer' || vm.edgesScope === 'customer_user') { |
339 | 339 | fetchEdgesFunction = function (pageLink, edgeType) { |
340 | - return edgeService.getCustomerEdges(customerId, pageLink, true, null, edgeType); | |
340 | + return edgeService.getCustomerEdges(customerId, pageLink, true, edgeType, null); | |
341 | 341 | }; |
342 | 342 | deleteEdgeFunction = function (edgeId) { |
343 | 343 | return edgeService.unassignEdgeFromCustomer(edgeId); | ... | ... |
... | ... | @@ -107,7 +107,7 @@ export default function RuleChainsController(ruleChainService, userService, impo |
107 | 107 | var deleteRuleChainFunction = null; |
108 | 108 | |
109 | 109 | if (edgeId) { |
110 | - edgeService.getEdge(edgeId).then( | |
110 | + edgeService.getEdge(edgeId, true, null).then( | |
111 | 111 | function success(edge) { |
112 | 112 | vm.edge = edge; |
113 | 113 | } | ... | ... |