Commit e3caf24a9b337805854d167b01535ff42023d573

Authored by AndrewVolosytnykhThingsboard
Committed by Andrew Shvayka
1 parent 5d64775f

Removed redundant parameter for AlarmController, AlarmQuery and RestClient.getAlarms

@@ -46,8 +46,6 @@ import org.thingsboard.server.queue.util.TbCoreComponent; @@ -46,8 +46,6 @@ import org.thingsboard.server.queue.util.TbCoreComponent;
46 import org.thingsboard.server.service.security.permission.Operation; 46 import org.thingsboard.server.service.security.permission.Operation;
47 import org.thingsboard.server.service.security.permission.Resource; 47 import org.thingsboard.server.service.security.permission.Resource;
48 48
49 -import java.util.UUID;  
50 -  
51 @RestController 49 @RestController
52 @TbCoreComponent 50 @TbCoreComponent
53 @RequestMapping("/api") 51 @RequestMapping("/api")
@@ -177,7 +175,6 @@ public class AlarmController extends BaseController { @@ -177,7 +175,6 @@ public class AlarmController extends BaseController {
177 @RequestParam(required = false) String sortOrder, 175 @RequestParam(required = false) String sortOrder,
178 @RequestParam(required = false) Long startTime, 176 @RequestParam(required = false) Long startTime,
179 @RequestParam(required = false) Long endTime, 177 @RequestParam(required = false) Long endTime,
180 - @RequestParam(required = false) String offset,  
181 @RequestParam(required = false) Boolean fetchOriginator 178 @RequestParam(required = false) Boolean fetchOriginator
182 ) throws ThingsboardException { 179 ) throws ThingsboardException {
183 checkParameter("EntityId", strEntityId); 180 checkParameter("EntityId", strEntityId);
@@ -191,12 +188,9 @@ public class AlarmController extends BaseController { @@ -191,12 +188,9 @@ public class AlarmController extends BaseController {
191 } 188 }
192 checkEntityId(entityId, Operation.READ); 189 checkEntityId(entityId, Operation.READ);
193 TimePageLink pageLink = createTimePageLink(pageSize, page, textSearch, sortProperty, sortOrder, startTime, endTime); 190 TimePageLink pageLink = createTimePageLink(pageSize, page, textSearch, sortProperty, sortOrder, startTime, endTime);
194 - UUID idOffsetUuid = null;  
195 - if (StringUtils.isNotEmpty(offset)) {  
196 - idOffsetUuid = toUUID(offset);  
197 - } 191 +
198 try { 192 try {
199 - return checkNotNull(alarmService.findAlarms(getCurrentUser().getTenantId(), new AlarmQuery(entityId, pageLink, alarmSearchStatus, alarmStatus, fetchOriginator, idOffsetUuid)).get()); 193 + return checkNotNull(alarmService.findAlarms(getCurrentUser().getTenantId(), new AlarmQuery(entityId, pageLink, alarmSearchStatus, alarmStatus, fetchOriginator)).get());
200 } catch (Exception e) { 194 } catch (Exception e) {
201 throw handleException(e); 195 throw handleException(e);
202 } 196 }
@@ -19,11 +19,8 @@ import lombok.AllArgsConstructor; @@ -19,11 +19,8 @@ import lombok.AllArgsConstructor;
19 import lombok.Builder; 19 import lombok.Builder;
20 import lombok.Data; 20 import lombok.Data;
21 import org.thingsboard.server.common.data.id.EntityId; 21 import org.thingsboard.server.common.data.id.EntityId;
22 -import org.thingsboard.server.common.data.id.TenantId;  
23 import org.thingsboard.server.common.data.page.TimePageLink; 22 import org.thingsboard.server.common.data.page.TimePageLink;
24 23
25 -import java.util.UUID;  
26 -  
27 /** 24 /**
28 * Created by ashvayka on 11.05.17. 25 * Created by ashvayka on 11.05.17.
29 */ 26 */
@@ -37,6 +34,5 @@ public class AlarmQuery { @@ -37,6 +34,5 @@ public class AlarmQuery {
37 private AlarmSearchStatus searchStatus; 34 private AlarmSearchStatus searchStatus;
38 private AlarmStatus status; 35 private AlarmStatus status;
39 private Boolean fetchOriginator; 36 private Boolean fetchOriginator;
40 - private UUID idOffset;  
41 37
42 } 38 }
@@ -121,13 +121,11 @@ import org.thingsboard.server.common.data.widget.WidgetsBundle; @@ -121,13 +121,11 @@ import org.thingsboard.server.common.data.widget.WidgetsBundle;
121 import java.io.Closeable; 121 import java.io.Closeable;
122 import java.io.IOException; 122 import java.io.IOException;
123 import java.net.URI; 123 import java.net.URI;
124 -import java.util.Arrays;  
125 import java.util.Collections; 124 import java.util.Collections;
126 import java.util.HashMap; 125 import java.util.HashMap;
127 import java.util.List; 126 import java.util.List;
128 import java.util.Map; 127 import java.util.Map;
129 import java.util.Optional; 128 import java.util.Optional;
130 -import java.util.UUID;  
131 import java.util.concurrent.ConcurrentHashMap; 129 import java.util.concurrent.ConcurrentHashMap;
132 import java.util.concurrent.ExecutorService; 130 import java.util.concurrent.ExecutorService;
133 import java.util.concurrent.Executors; 131 import java.util.concurrent.Executors;
@@ -306,11 +304,12 @@ public class RestClient implements ClientHttpRequestInterceptor, Closeable { @@ -306,11 +304,12 @@ public class RestClient implements ClientHttpRequestInterceptor, Closeable {
306 restTemplate.postForLocation(baseURL + "/api/alarm/{alarmId}/clear", null, alarmId.getId()); 304 restTemplate.postForLocation(baseURL + "/api/alarm/{alarmId}/clear", null, alarmId.getId());
307 } 305 }
308 306
309 - public PageData<AlarmInfo> getAlarms(EntityId entityId, AlarmSearchStatus searchStatus, AlarmStatus status, TimePageLink pageLink, UUID offset, Boolean fetchOriginator) { 307 + public PageData<AlarmInfo> getAlarms(EntityId entityId, AlarmSearchStatus searchStatus, AlarmStatus status, TimePageLink pageLink, Boolean fetchOriginator) {
310 String urlSecondPart = "/api/alarm/{entityType}/{entityId}?fetchOriginator={fetchOriginator}&"; 308 String urlSecondPart = "/api/alarm/{entityType}/{entityId}?fetchOriginator={fetchOriginator}&";
311 Map<String, String> params = new HashMap<>(); 309 Map<String, String> params = new HashMap<>();
312 params.put("entityType", entityId.getEntityType().name()); 310 params.put("entityType", entityId.getEntityType().name());
313 params.put("entityId", entityId.getId().toString()); 311 params.put("entityId", entityId.getId().toString());
  312 + params.put("fetchOriginator", String.valueOf(fetchOriginator));
314 if(searchStatus != null) { 313 if(searchStatus != null) {
315 params.put("searchStatus", searchStatus.name()); 314 params.put("searchStatus", searchStatus.name());
316 urlSecondPart += "searchStatus={searchStatus}&"; 315 urlSecondPart += "searchStatus={searchStatus}&";
@@ -319,11 +318,7 @@ public class RestClient implements ClientHttpRequestInterceptor, Closeable { @@ -319,11 +318,7 @@ public class RestClient implements ClientHttpRequestInterceptor, Closeable {
319 params.put("status", status.name()); 318 params.put("status", status.name());
320 urlSecondPart += "status={status}&"; 319 urlSecondPart += "status={status}&";
321 } 320 }
322 - params.put("fetchOriginator", String.valueOf(fetchOriginator));  
323 - if(offset != null) {  
324 - params.put("offset", offset.toString());  
325 - urlSecondPart += "offset={offset}&";  
326 - } 321 +
327 addTimePageLinkToParam(params, pageLink); 322 addTimePageLinkToParam(params, pageLink);
328 323
329 return restTemplate.exchange( 324 return restTemplate.exchange(