Commit ed6de776e458e53b9085b554927f7f4cfd771233

Authored by mp-loki
1 parent e80cb31a

removeById fixed

... ... @@ -66,6 +66,7 @@ public abstract class JpaAbstractDao<E extends BaseEntity<D>, D> implements Dao<
66 66 }
67 67
68 68 @Override
  69 + @Transactional(propagation = REQUIRES_NEW)
69 70 public D findById(UUID key) {
70 71 log.debug("Get entity by key {}", key);
71 72 E entity = getCrudRepository().findOne(key);
... ... @@ -86,7 +87,7 @@ public abstract class JpaAbstractDao<E extends BaseEntity<D>, D> implements Dao<
86 87 public boolean removeById(UUID key) {
87 88 getCrudRepository().delete(key);
88 89 log.debug("Remove request: {}", key);
89   - return getCrudRepository().equals(key);
  90 + return getCrudRepository().findOne(key) == null;
90 91 }
91 92
92 93 @Override
... ...
... ... @@ -31,8 +31,7 @@ import java.io.IOException;
31 31 import java.util.List;
32 32 import java.util.UUID;
33 33
34   -import static org.junit.Assert.assertEquals;
35   -import static org.junit.Assert.assertNotNull;
  34 +import static org.junit.Assert.*;
36 35
37 36 /**
38 37 * Created by Valerii Sosliuk on 4/30/2017.
... ... @@ -46,10 +45,7 @@ public class JpaBaseRuleDaoTest extends AbstractJpaDaoTest {
46 45 @DatabaseSetup("classpath:dbunit/empty_dataset.xml")
47 46 public void testSave() throws IOException {
48 47 UUID id = UUIDs.timeBased();
49   - RuleMetaData ruleMetaData = new RuleMetaData();
50   - ruleMetaData.setId(new RuleId(id));
51   - ruleMetaData.setTenantId(new TenantId(UUIDs.timeBased()));
52   - ruleMetaData.setName("test");
  48 + RuleMetaData ruleMetaData = getRuleMetaData(id);
53 49 String filters = "{\"filters\":\"value-1\"}";
54 50 String processor = "{\"processor\":\"value-2\"}";
55 51 String action = "{\"action\":\"value-3\"}";
... ... @@ -69,6 +65,19 @@ public class JpaBaseRuleDaoTest extends AbstractJpaDaoTest {
69 65 }
70 66
71 67 @Test
  68 + @DatabaseSetup("classpath:dbunit/empty_dataset.xml")
  69 + public void testDelete() throws IOException {
  70 + UUID id = UUIDs.timeBased();
  71 + RuleMetaData ruleMetaData = getRuleMetaData(id);
  72 + ruleDao.save(ruleMetaData);
  73 + RuleMetaData savedRule = ruleDao.findById(id);
  74 + assertNotNull(savedRule);
  75 + assertTrue(ruleDao.removeById(id));
  76 + RuleMetaData afterDelete = ruleDao.findById(id);
  77 + assertNull(afterDelete);
  78 + }
  79 +
  80 + @Test
72 81 @DatabaseSetup("classpath:dbunit/rule.xml")
73 82 public void testFindRulesByPlugin() {
74 83 assertEquals(3, ruleDao.findRulesByPlugin("token_1").size());
... ... @@ -135,4 +144,13 @@ public class JpaBaseRuleDaoTest extends AbstractJpaDaoTest {
135 144 ruleMetaData.setPluginToken(pluginToken);
136 145 ruleDao.save(ruleMetaData);
137 146 }
  147 +
  148 + private RuleMetaData getRuleMetaData(UUID id) throws IOException {
  149 + RuleMetaData ruleMetaData = new RuleMetaData();
  150 + ruleMetaData.setId(new RuleId(id));
  151 + ruleMetaData.setTenantId(new TenantId(UUIDs.timeBased()));
  152 + ruleMetaData.setName("test");
  153 +
  154 + return ruleMetaData;
  155 + }
138 156 }
... ...