Commit fe27cb1a319ea9a201ab512b80cbab5308855c0b
Committed by
Andrew Shvayka
1 parent
8e8c1ae8
fix NPE in findAlarms from JpaAlarmDao
(cherry picked from commit 2c1fd8e0436d4b4ae12cd385114c2ae890923c5e)
Showing
2 changed files
with
4 additions
and
6 deletions
@@ -25,6 +25,7 @@ import org.thingsboard.server.dao.model.sql.AlarmEntity; | @@ -25,6 +25,7 @@ import org.thingsboard.server.dao.model.sql.AlarmEntity; | ||
25 | import org.thingsboard.server.dao.model.sql.AlarmInfoEntity; | 25 | import org.thingsboard.server.dao.model.sql.AlarmInfoEntity; |
26 | 26 | ||
27 | import java.util.List; | 27 | import java.util.List; |
28 | +import java.util.Set; | ||
28 | import java.util.UUID; | 29 | import java.util.UUID; |
29 | 30 | ||
30 | /** | 31 | /** |
@@ -70,7 +71,7 @@ public interface AlarmRepository extends CrudRepository<AlarmEntity, UUID> { | @@ -70,7 +71,7 @@ public interface AlarmRepository extends CrudRepository<AlarmEntity, UUID> { | ||
70 | @Param("affectedEntityType") String affectedEntityType, | 71 | @Param("affectedEntityType") String affectedEntityType, |
71 | @Param("startTime") Long startTime, | 72 | @Param("startTime") Long startTime, |
72 | @Param("endTime") Long endTime, | 73 | @Param("endTime") Long endTime, |
73 | - @Param("alarmStatuses") List<AlarmStatus> alarmStatuses, | 74 | + @Param("alarmStatuses") Set<AlarmStatus> alarmStatuses, |
74 | @Param("searchText") String searchText, | 75 | @Param("searchText") String searchText, |
75 | Pageable pageable); | 76 | Pageable pageable); |
76 | 77 |
@@ -24,14 +24,12 @@ import org.springframework.stereotype.Component; | @@ -24,14 +24,12 @@ import org.springframework.stereotype.Component; | ||
24 | import org.thingsboard.server.common.data.alarm.Alarm; | 24 | import org.thingsboard.server.common.data.alarm.Alarm; |
25 | import org.thingsboard.server.common.data.alarm.AlarmInfo; | 25 | import org.thingsboard.server.common.data.alarm.AlarmInfo; |
26 | import org.thingsboard.server.common.data.alarm.AlarmQuery; | 26 | import org.thingsboard.server.common.data.alarm.AlarmQuery; |
27 | -import org.thingsboard.server.common.data.alarm.AlarmSearchStatus; | ||
28 | import org.thingsboard.server.common.data.alarm.AlarmStatus; | 27 | import org.thingsboard.server.common.data.alarm.AlarmStatus; |
29 | import org.thingsboard.server.common.data.id.CustomerId; | 28 | import org.thingsboard.server.common.data.id.CustomerId; |
30 | import org.thingsboard.server.common.data.id.EntityId; | 29 | import org.thingsboard.server.common.data.id.EntityId; |
31 | import org.thingsboard.server.common.data.id.TenantId; | 30 | import org.thingsboard.server.common.data.id.TenantId; |
32 | import org.thingsboard.server.common.data.page.PageData; | 31 | import org.thingsboard.server.common.data.page.PageData; |
33 | import org.thingsboard.server.common.data.query.AlarmData; | 32 | import org.thingsboard.server.common.data.query.AlarmData; |
34 | -import org.thingsboard.server.common.data.query.AlarmDataPageLink; | ||
35 | import org.thingsboard.server.common.data.query.AlarmDataQuery; | 33 | import org.thingsboard.server.common.data.query.AlarmDataQuery; |
36 | import org.thingsboard.server.dao.DaoUtil; | 34 | import org.thingsboard.server.dao.DaoUtil; |
37 | import org.thingsboard.server.dao.alarm.AlarmDao; | 35 | import org.thingsboard.server.dao.alarm.AlarmDao; |
@@ -40,7 +38,6 @@ import org.thingsboard.server.dao.relation.RelationDao; | @@ -40,7 +38,6 @@ import org.thingsboard.server.dao.relation.RelationDao; | ||
40 | import org.thingsboard.server.dao.sql.JpaAbstractDao; | 38 | import org.thingsboard.server.dao.sql.JpaAbstractDao; |
41 | import org.thingsboard.server.dao.sql.query.AlarmQueryRepository; | 39 | import org.thingsboard.server.dao.sql.query.AlarmQueryRepository; |
42 | 40 | ||
43 | -import java.util.ArrayList; | ||
44 | import java.util.Collection; | 41 | import java.util.Collection; |
45 | import java.util.Collections; | 42 | import java.util.Collections; |
46 | import java.util.List; | 43 | import java.util.List; |
@@ -102,7 +99,7 @@ public class JpaAlarmDao extends JpaAbstractDao<AlarmEntity, Alarm> implements A | @@ -102,7 +99,7 @@ public class JpaAlarmDao extends JpaAbstractDao<AlarmEntity, Alarm> implements A | ||
102 | Set<AlarmStatus> statusSet = null; | 99 | Set<AlarmStatus> statusSet = null; |
103 | if (query.getSearchStatus() != null) { | 100 | if (query.getSearchStatus() != null) { |
104 | statusSet = query.getSearchStatus().getStatuses(); | 101 | statusSet = query.getSearchStatus().getStatuses(); |
105 | - } else if (query.getStatus() != null){ | 102 | + } else if (query.getStatus() != null) { |
106 | statusSet = Collections.singleton(query.getStatus()); | 103 | statusSet = Collections.singleton(query.getStatus()); |
107 | } | 104 | } |
108 | return DaoUtil.toPageData( | 105 | return DaoUtil.toPageData( |
@@ -112,7 +109,7 @@ public class JpaAlarmDao extends JpaAbstractDao<AlarmEntity, Alarm> implements A | @@ -112,7 +109,7 @@ public class JpaAlarmDao extends JpaAbstractDao<AlarmEntity, Alarm> implements A | ||
112 | affectedEntity.getEntityType().name(), | 109 | affectedEntity.getEntityType().name(), |
113 | query.getPageLink().getStartTime(), | 110 | query.getPageLink().getStartTime(), |
114 | query.getPageLink().getEndTime(), | 111 | query.getPageLink().getEndTime(), |
115 | - new ArrayList<>(statusSet), | 112 | + statusSet, |
116 | Objects.toString(query.getPageLink().getTextSearch(), ""), | 113 | Objects.toString(query.getPageLink().getTextSearch(), ""), |
117 | DaoUtil.toPageable(query.getPageLink()) | 114 | DaoUtil.toPageable(query.getPageLink()) |
118 | ) | 115 | ) |