Commit ffc56f5c233fdae8aaae55162b8f4a1f4ec266a4
1 parent
af1524b2
Add prefix to device credentials cache keys.
Showing
4 changed files
with
8 additions
and
6 deletions
@@ -22,9 +22,11 @@ import org.thingsboard.server.dao.device.DeviceCredentialsService; | @@ -22,9 +22,11 @@ import org.thingsboard.server.dao.device.DeviceCredentialsService; | ||
22 | 22 | ||
23 | import java.lang.reflect.Method; | 23 | import java.lang.reflect.Method; |
24 | 24 | ||
25 | +import static org.thingsboard.server.common.data.CacheConstants.DEVICE_CREDENTIALS_CACHE; | ||
26 | + | ||
25 | public class PreviousDeviceCredentialsIdKeyGenerator implements KeyGenerator { | 27 | public class PreviousDeviceCredentialsIdKeyGenerator implements KeyGenerator { |
26 | 28 | ||
27 | - private static final String NOT_VALID_DEVICE = "notValidDeviceCredentialsId"; | 29 | + private static final String NOT_VALID_DEVICE = DEVICE_CREDENTIALS_CACHE + "_notValidDeviceCredentialsId"; |
28 | 30 | ||
29 | @Override | 31 | @Override |
30 | public Object generate(Object o, Method method, Object... objects) { | 32 | public Object generate(Object o, Method method, Object... objects) { |
@@ -34,7 +36,7 @@ public class PreviousDeviceCredentialsIdKeyGenerator implements KeyGenerator { | @@ -34,7 +36,7 @@ public class PreviousDeviceCredentialsIdKeyGenerator implements KeyGenerator { | ||
34 | if (deviceCredentials.getDeviceId() != null) { | 36 | if (deviceCredentials.getDeviceId() != null) { |
35 | DeviceCredentials oldDeviceCredentials = deviceCredentialsService.findDeviceCredentialsByDeviceId(tenantId, deviceCredentials.getDeviceId()); | 37 | DeviceCredentials oldDeviceCredentials = deviceCredentialsService.findDeviceCredentialsByDeviceId(tenantId, deviceCredentials.getDeviceId()); |
36 | if (oldDeviceCredentials != null) { | 38 | if (oldDeviceCredentials != null) { |
37 | - return oldDeviceCredentials.getCredentialsId(); | 39 | + return DEVICE_CREDENTIALS_CACHE + "_" + oldDeviceCredentials.getCredentialsId(); |
38 | } | 40 | } |
39 | } | 41 | } |
40 | return NOT_VALID_DEVICE; | 42 | return NOT_VALID_DEVICE; |
@@ -54,7 +54,7 @@ public class DeviceCredentialsServiceImpl implements DeviceCredentialsService { | @@ -54,7 +54,7 @@ public class DeviceCredentialsServiceImpl implements DeviceCredentialsService { | ||
54 | } | 54 | } |
55 | 55 | ||
56 | @Override | 56 | @Override |
57 | - @Cacheable(cacheNames = DEVICE_CREDENTIALS_CACHE, unless = "#result == null") | 57 | + @Cacheable(cacheNames = DEVICE_CREDENTIALS_CACHE, key = "'deviceCredentials_' + #credentialsId", unless = "#result == null") |
58 | public DeviceCredentials findDeviceCredentialsByCredentialsId(String credentialsId) { | 58 | public DeviceCredentials findDeviceCredentialsByCredentialsId(String credentialsId) { |
59 | log.trace("Executing findDeviceCredentialsByCredentialsId [{}]", credentialsId); | 59 | log.trace("Executing findDeviceCredentialsByCredentialsId [{}]", credentialsId); |
60 | validateString(credentialsId, "Incorrect credentialsId " + credentialsId); | 60 | validateString(credentialsId, "Incorrect credentialsId " + credentialsId); |
@@ -89,7 +89,7 @@ public class DeviceCredentialsServiceImpl implements DeviceCredentialsService { | @@ -89,7 +89,7 @@ public class DeviceCredentialsServiceImpl implements DeviceCredentialsService { | ||
89 | } | 89 | } |
90 | 90 | ||
91 | @Override | 91 | @Override |
92 | - @CacheEvict(cacheNames = DEVICE_CREDENTIALS_CACHE, key = "#deviceCredentials.credentialsId") | 92 | + @CacheEvict(cacheNames = DEVICE_CREDENTIALS_CACHE, key = "'deviceCredentials_' + #deviceCredentials.credentialsId") |
93 | public void deleteDeviceCredentials(TenantId tenantId, DeviceCredentials deviceCredentials) { | 93 | public void deleteDeviceCredentials(TenantId tenantId, DeviceCredentials deviceCredentials) { |
94 | log.trace("Executing deleteDeviceCredentials [{}]", deviceCredentials); | 94 | log.trace("Executing deleteDeviceCredentials [{}]", deviceCredentials); |
95 | deviceCredentialsDao.removeById(tenantId, deviceCredentials.getUuidId()); | 95 | deviceCredentialsDao.removeById(tenantId, deviceCredentials.getUuidId()); |
dao/src/test/java/org/thingsboard/server/dao/service/nosql/DeviceCredentialCacheServiceNoSqlTest.java
renamed from
dao/src/test/java/org/thingsboard/server/dao/service/nosql/DeviceCredentialCacheNoSqlTest.java
@@ -19,5 +19,5 @@ import org.thingsboard.server.dao.service.BaseDeviceCredentialsCacheTest; | @@ -19,5 +19,5 @@ import org.thingsboard.server.dao.service.BaseDeviceCredentialsCacheTest; | ||
19 | import org.thingsboard.server.dao.service.DaoNoSqlTest; | 19 | import org.thingsboard.server.dao.service.DaoNoSqlTest; |
20 | 20 | ||
21 | @DaoNoSqlTest | 21 | @DaoNoSqlTest |
22 | -public class DeviceCredentialCacheNoSqlTest extends BaseDeviceCredentialsCacheTest { | 22 | +public class DeviceCredentialCacheServiceNoSqlTest extends BaseDeviceCredentialsCacheTest { |
23 | } | 23 | } |
dao/src/test/java/org/thingsboard/server/dao/service/sql/DeviceCredentialsCacheServiceSqlTest.java
renamed from
dao/src/test/java/org/thingsboard/server/dao/service/sql/DeviceCredentialsCacheSqlTest.java
@@ -19,5 +19,5 @@ import org.thingsboard.server.dao.service.BaseDeviceCredentialsCacheTest; | @@ -19,5 +19,5 @@ import org.thingsboard.server.dao.service.BaseDeviceCredentialsCacheTest; | ||
19 | import org.thingsboard.server.dao.service.DaoSqlTest; | 19 | import org.thingsboard.server.dao.service.DaoSqlTest; |
20 | 20 | ||
21 | @DaoSqlTest | 21 | @DaoSqlTest |
22 | -public class DeviceCredentialsCacheSqlTest extends BaseDeviceCredentialsCacheTest { | 22 | +public class DeviceCredentialsCacheServiceSqlTest extends BaseDeviceCredentialsCacheTest { |
23 | } | 23 | } |